From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: Question about r8a7779 ether
Date: Thu, 31 Oct 2013 09:30:39 +0000 [thread overview]
Message-ID: <20131031093034.GA24672@verge.net.au> (raw)
In-Reply-To: <87fvrhq143.wl%kuninori.morimoto.gx@renesas.com>
On Thu, Oct 31, 2013 at 01:46:24AM -0700, Kuninori Morimoto wrote:
>
> Hi
>
> You know, we are removing r8a7779_add_xxx_device()
> from setup-r8a7779.
> When I cleaned these functions from setup-r8a7779,
> if my memory was correct, Sergei requested not to clean up
> r8a7779_add_ether_device(), since he sends patch for marzen.
>
> But current marzen still doesn't use it.
> I'm checking renesas-devel-v3.12-rc7-20131030 tag.
> According to git log, r8a7779_add_ether_device() was added Apr 2013,
> and today, Nov 2013.
Its still October, just :^)
> Does Marzen need it ?
> If yes, who has this patch ? or what is current status of it ?
>
> No one is using it in this 6 month.
> (and normal marzen board doesn't have sh_eth implement).
> Can I remove it anyway ?
>
> r8a7779_add_ether_device() was added by this commit
From my POV it sounds reasonable to remove it.
>
> dace48d04dee46a3409d5e13cd98031522e46377
> Author: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Date: Thu Apr 4 18:53:50 2013 +0000
>
> ARM: shmobile: R8A7779: add Ether support
>
> Add Ether clock and platform device for R8A7779 SoC; add a function to register
> this device with board-specific platform data.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-10-31 9:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 8:46 Question about r8a7779 ether Kuninori Morimoto
2013-10-31 9:30 ` Simon Horman [this message]
2013-10-31 19:36 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031093034.GA24672@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).