From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] RM: shmobile: lager: phy fixup needs CONFIG_PHYLIB
Date: Fri, 01 Nov 2013 00:43:59 +0000 [thread overview]
Message-ID: <20131101004359.GK6818@verge.net.au> (raw)
In-Reply-To: <5272CC16.3020700@cogentembedded.com>
On Fri, Nov 01, 2013 at 12:31:02AM +0300, Sergei Shtylyov wrote:
> On 10/31/2013 09:31 AM, Simon Horman wrote:
>
> >Do not build the phy fixup unless CONFIG_PHYLIB is enabled.
> >Other than not being useful it is also not possible to compile
>
> s/compile/link/.
>
> >the code under this condition as phy_register_fixup_for_id()
> >is not defined.
>
> Not only this function is absent...
>
> >This problem was introduced by 48c8b96f21817aad
> >("ARM: shmobile: Lager: add Micrel KSZ8041 PHY fixup")
>
> >Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >---
> > arch/arm/mach-shmobile/board-lager.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
>
> >diff --git a/arch/arm/mach-shmobile/board-lager.c b/arch/arm/mach-shmobile/board-lager.c
> >index 78a31b6..d1a8ddd 100644
> >--- a/arch/arm/mach-shmobile/board-lager.c
> >+++ b/arch/arm/mach-shmobile/board-lager.c
> >@@ -245,7 +245,9 @@ static void __init lager_init(void)
> > {
> > lager_add_standard_devices();
> >
> >- phy_register_fixup_for_id("r8a7790-ether-ff:01", lager_ksz8041_fixup);
> >+ if (IS_ENABLED(CONFIG_PHYLIB))
> >+ phy_register_fixup_for_id("r8a7790-ether-ff:01",
> >+ lager_ksz8041_fixup);
>
> Perhaps you would consider enclosing the fixup function itself
> into #ifdef as it causes link errors as well? Doesn't seem
> necessary as gcc probably drops it anyway but for completeness'
> sake...
My understanding of the motivation for IS_ENABLED() is to
take advantage of gcc optimising away unused code and making such
problems disappear.
With this patch in place do you still see any warnings?
next prev parent reply other threads:[~2013-11-01 0:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 6:31 [PATCH] RM: shmobile: lager: phy fixup needs CONFIG_PHYLIB Simon Horman
2013-10-31 20:31 ` Sergei Shtylyov
2013-11-01 0:43 ` Simon Horman [this message]
2013-11-01 23:30 ` Sergei Shtylyov
2013-11-04 23:58 ` Simon Horman
2013-11-05 16:53 ` Sergei Shtylyov
2013-11-05 20:25 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131101004359.GK6818@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).