[PATCH] ARM: shmobile: r8a7790: Correct typo in clocks

[PATCH] ARM: shmobile: r8a7790: Correct typo in clocks

[Simon Horman]

This is the r8a7790 SoC not the r8a77a4 SoC and
clocks are updated in r8a7790_clock_init.  not r8a73a4_clock_init.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/mach-shmobile/clock-r8a7790.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-shmobile/clock-r8a7790.c b/arch/arm/mach-shmobile/clock-r8a7790.c
index 9fa39d1..6107571 100644
--- a/arch/arm/mach-shmobile/clock-r8a7790.c
+++ b/arch/arm/mach-shmobile/clock-r8a7790.c
@@ -77,7 +77,7 @@ static struct sh_clk_ops followparent_clk_ops = {
 };
 
 static struct clk main_clk = {
-	/* .parent will be set r8a73a4_clock_init */
+	/* .parent will be set r8a7790_clock_init */
 	.ops	= &followparent_clk_ops,
 };
 
-- 
1.8.4

Re: [PATCH] ARM: shmobile: r8a7790: Correct typo in clocks

[Kuninori Morimoto]

Hi Simon

> This is the r8a7790 SoC not the r8a77a4 SoC and
> clocks are updated in r8a7790_clock_init.  not r8a73a4_clock_init.
> 
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm/mach-shmobile/clock-r8a7790.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-shmobile/clock-r8a7790.c b/arch/arm/mach-shmobile/clock-r8a7790.c
> index 9fa39d1..6107571 100644
> --- a/arch/arm/mach-shmobile/clock-r8a7790.c
> +++ b/arch/arm/mach-shmobile/clock-r8a7790.c
> @@ -77,7 +77,7 @@ static struct sh_clk_ops followparent_clk_ops = {
>  };
>  
>  static struct clk main_clk = {
> -	/* .parent will be set r8a73a4_clock_init */
> +	/* .parent will be set r8a7790_clock_init */
>  	.ops	= &followparent_clk_ops,
>  };

Hahaha, Nice catch :)

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Best regards
---
Kuninori Morimoto

Re: [PATCH] ARM: shmobile: r8a7790: Correct typo in clocks

[Simon Horman]

On Tue, Nov 05, 2013 at 10:06:20PM -0800, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > This is the r8a7790 SoC not the r8a77a4 SoC and
> > clocks are updated in r8a7790_clock_init.  not r8a73a4_clock_init.

Ironically there is a typo in the line above.
I'll fix that up before applying the patch.

> > 
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> >  arch/arm/mach-shmobile/clock-r8a7790.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/mach-shmobile/clock-r8a7790.c b/arch/arm/mach-shmobile/clock-r8a7790.c
> > index 9fa39d1..6107571 100644
> > --- a/arch/arm/mach-shmobile/clock-r8a7790.c
> > +++ b/arch/arm/mach-shmobile/clock-r8a7790.c
> > @@ -77,7 +77,7 @@ static struct sh_clk_ops followparent_clk_ops = {
> >  };
> >  
> >  static struct clk main_clk = {
> > -	/* .parent will be set r8a73a4_clock_init */
> > +	/* .parent will be set r8a7790_clock_init */
> >  	.ops	= &followparent_clk_ops,
> >  };
> 
> Hahaha, Nice catch :)
> 
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Best regards
> ---
> Kuninori Morimoto
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH] ARM: shmobile: r8a7790: Correct typo in clocks

[Simon Horman]

On Wed, Nov 06, 2013 at 05:35:58PM +0900, Simon Horman wrote:
> On Tue, Nov 05, 2013 at 10:06:20PM -0800, Kuninori Morimoto wrote:
> > 
> > Hi Simon
> > 
> > > This is the r8a7790 SoC not the r8a77a4 SoC and
> > > clocks are updated in r8a7790_clock_init.  not r8a73a4_clock_init.
> 
> Ironically there is a typo in the line above.
> I'll fix that up before applying the patch.

I have queued-up the following:

From: Simon Horman <horms+renesas@verge.net.au>

ARM: shmobile: r8a7790: Correct typo in clocks

This is the r8a7790 SoC not the r8a77a4 SoC and
clocks are updated in r8a7790_clock_init not r8a73a4_clock_init.

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/mach-shmobile/clock-r8a7790.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-shmobile/clock-r8a7790.c b/arch/arm/mach-shmobile/clock-r8a7790.c
index a64f965..fa1b477 100644
--- a/arch/arm/mach-shmobile/clock-r8a7790.c
+++ b/arch/arm/mach-shmobile/clock-r8a7790.c
@@ -77,7 +77,7 @@ static struct sh_clk_ops followparent_clk_ops = {
 };
 
 static struct clk main_clk = {
-	/* .parent will be set r8a73a4_clock_init */
+	/* .parent will be set r8a7790_clock_init */
 	.ops	= &followparent_clk_ops,
 };
 
-- 
1.8.4

[PATCH] ARM: shmobile: r8a7790: Correct SYS DMAC clock defines

[Simon Horman]

This brings the implementation into line with the documentation.

This problem was introduced when SYS DMAC clock defines were added by
ac991dce6498b5fc ("ARM: shmobile: r8a7790: Add clock index macros for DT
sources") in v3.13-rc2. I do not believe this results in any problems as
these defines do not appear to be used anywhere yet.

Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 include/dt-bindings/clock/r8a7790-clock.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/dt-bindings/clock/r8a7790-clock.h b/include/dt-bindings/clock/r8a7790-clock.h
index 859e9be..6548a5f 100644
--- a/include/dt-bindings/clock/r8a7790-clock.h
+++ b/include/dt-bindings/clock/r8a7790-clock.h
@@ -46,8 +46,8 @@
 #define R8A7790_CLK_MSIOF1		8
 #define R8A7790_CLK_MSIOF3		15
 #define R8A7790_CLK_SCIFB2		16
-#define R8A7790_CLK_SYS_DMAC0		18
-#define R8A7790_CLK_SYS_DMAC1		19
+#define R8A7790_CLK_SYS_DMAC1		18
+#define R8A7790_CLK_SYS_DMAC0		19
 
 /* MSTP3 */
 #define R8A7790_CLK_TPU0		4
-- 
1.8.5.2

Re: [PATCH] ARM: shmobile: r8a7790: Correct SYS DMAC clock defines

[Laurent Pinchart]

Hi Simon,

Thank you for the patch.

On Thursday 06 February 2014 09:25:01 Simon Horman wrote:
> This brings the implementation into line with the documentation.
> 
> This problem was introduced when SYS DMAC clock defines were added by
> ac991dce6498b5fc ("ARM: shmobile: r8a7790: Add clock index macros for DT
> sources") in v3.13-rc2. I do not believe this results in any problems as
> these defines do not appear to be used anywhere yet.
> 
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  include/dt-bindings/clock/r8a7790-clock.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/dt-bindings/clock/r8a7790-clock.h
> b/include/dt-bindings/clock/r8a7790-clock.h index 859e9be..6548a5f 100644
> --- a/include/dt-bindings/clock/r8a7790-clock.h
> +++ b/include/dt-bindings/clock/r8a7790-clock.h
> @@ -46,8 +46,8 @@
>  #define R8A7790_CLK_MSIOF1		8
>  #define R8A7790_CLK_MSIOF3		15
>  #define R8A7790_CLK_SCIFB2		16
> -#define R8A7790_CLK_SYS_DMAC0		18
> -#define R8A7790_CLK_SYS_DMAC1		19
> +#define R8A7790_CLK_SYS_DMAC1		18
> +#define R8A7790_CLK_SYS_DMAC0		19
> 
>  /* MSTP3 */
>  #define R8A7790_CLK_TPU0		4

-- 
Regards,

Laurent Pinchart

Re: [PATCH] ARM: shmobile: r8a7790: Correct SYS DMAC clock defines

[Simon Horman]

On Thu, Feb 06, 2014 at 11:28:52AM +0100, Laurent Pinchart wrote:
> Hi Simon,
> 
> Thank you for the patch.
> 
> On Thursday 06 February 2014 09:25:01 Simon Horman wrote:
> > This brings the implementation into line with the documentation.
> > 
> > This problem was introduced when SYS DMAC clock defines were added by
> > ac991dce6498b5fc ("ARM: shmobile: r8a7790: Add clock index macros for DT
> > sources") in v3.13-rc2. I do not believe this results in any problems as
> > these defines do not appear to be used anywhere yet.
> > 
> > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> 
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thanks, I have queued this up.

Re: [PATCH] ARM: shmobile: r8a7790: Correct SYS DMAC clock defines

[Ben Dooks]

On 06/02/14 00:25, Simon Horman wrote:
> This brings the implementation into line with the documentation.
>
> This problem was introduced when SYS DMAC clock defines were added by
> ac991dce6498b5fc ("ARM: shmobile: r8a7790: Add clock index macros for DT
> sources") in v3.13-rc2. I do not believe this results in any problems as
> these defines do not appear to be used anywhere yet.
>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Reviewed-by: Ben Dooks <ben.dooks@codethink.co.uk>

I agree, although I have yet to get the DMA working.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius