From: Magnus Damm <magnus.damm@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: linux-sh@vger.kernel.org, linus.walleij@linaro.org,
	grant.likely@secretlab.ca, horms@verge.net.au,
	laurent.pinchart@ideasonboard.com,
	Magnus Damm <magnus.damm@gmail.com>
Subject: [PATCH 03/03] gpio: em: Use lazy disable and mask on suspend
Date: Wed, 13 Nov 2013 22:59:55 +0000	[thread overview]
Message-ID: <20131113225955.21449.34737.sendpatchset@w520> (raw)
In-Reply-To: <20131113225927.21449.78044.sendpatchset@w520>
From: Magnus Damm <damm@opensource.se>
Set the ->irq_enable() and ->irq_disable() methods to NULL
to enable lazy disable of interrupts. Also extend the code
to set IRQCHIP_MASK_ON_SUSPEND which tells the core that
only IRQs marked as wakeups need to stay enabled during
Suspend-to-RAM.
Tested on the KZM9D board with GPIO-keys.
Signed-off-by: Magnus Damm <damm@opensource.se>
---
 drivers/gpio/gpio-em.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
--- 0006/drivers/gpio/gpio-em.c
+++ work/drivers/gpio/gpio-em.c	2013-11-13 22:18:21.000000000 +0900
@@ -336,10 +336,8 @@ static int em_gio_probe(struct platform_
 	irq_chip->name = name;
 	irq_chip->irq_mask = em_gio_irq_disable;
 	irq_chip->irq_unmask = em_gio_irq_enable;
-	irq_chip->irq_enable = em_gio_irq_enable;
-	irq_chip->irq_disable = em_gio_irq_disable;
 	irq_chip->irq_set_type = em_gio_irq_set_type;
-	irq_chip->flags	= IRQCHIP_SKIP_SET_WAKE;
+	irq_chip->flags	= IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MASK_ON_SUSPEND;
 
 	p->irq_domain = irq_domain_add_simple(pdev->dev.of_node,
 					      pdata->number_of_pins,
next prev parent reply	other threads:[~2013-11-13 22:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-13 22:59 [PATCH 00/03] gpio: R-Car and EM GPIO update Magnus Damm
2013-11-13 22:59 ` [PATCH 01/03] gpio: rcar: Use lazy disable and mask on suspend Magnus Damm
2013-11-14  0:07   ` Laurent Pinchart
2013-11-14  2:03     ` Magnus Damm
2013-11-14  2:17       ` Laurent Pinchart
2013-11-14  8:50         ` Magnus Damm
2013-11-14 14:57           ` Laurent Pinchart
2013-11-13 22:59 ` [PATCH 02/03] gpio: em: Setup gpiochip->dev Magnus Damm
2013-11-14  0:08   ` Laurent Pinchart
2013-11-13 22:59 ` Magnus Damm [this message]
2013-11-19  8:26 ` [PATCH 00/03] gpio: R-Car and EM GPIO update Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=20131113225955.21449.34737.sendpatchset@w520 \
    --to=magnus.damm@gmail.com \
    --cc=grant.likely@secretlab.ca \
    --cc=horms@verge.net.au \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).