From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: shmobile: r8a7790: Wait for status on all MSTP clocks
Date: Thu, 14 Nov 2013 04:14:03 +0000 [thread overview]
Message-ID: <20131114041356.GB22870@verge.net.au> (raw)
In-Reply-To: <1383066834-25956-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Wed, Nov 13, 2013 at 04:15:16PM +0100, Laurent Pinchart wrote:
> Hi Simon,
>
> On Thursday 31 October 2013 13:35:07 Laurent Pinchart wrote:
> > On Thursday 31 October 2013 14:36:06 Simon Horman wrote:
> > > On Tue, Oct 29, 2013 at 06:13:54PM +0100, Laurent Pinchart wrote:
> > > > From: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
> > > >
> > > > When enabling a module clock by clearing its bit in the MSTP control
> > > > register, the CPG requires waiting for the status register to signal
> > > > that the clock has started. Failure to do so will result in returning
> > > > from the clk_enable() call with the clock potientially still disabled,
> > > > leading to various race conditions and difficult to debug errors.
> > > >
> > > > Enable status wait for all MSTP clocks on the r8a7790.
> > >
> > > Is this patch independent of patch 1 of this series?
> >
> > Yes it is. The SH_CLK_MSTP32_STS macro is defined in patch 1/2.
>
> I had obviously read "Is this patch dependent".
>
> I'll submit a v2 with support for the r8a7779.
>
> Have you had a chance to chat with Paul about this ? Patch 1/2 introduces a
> feature that is disabled by default so it should have no influence at all on
> arch/sh.
No, I have not been successful in chatting to Paul.
I agree that it should be harmless enough.
I intend to queue up v2 once you post it.
prev parent reply other threads:[~2013-11-14 4:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 17:13 [PATCH 2/2] ARM: shmobile: r8a7790: Wait for status on all MSTP clocks Laurent Pinchart
2013-10-31 5:36 ` Simon Horman
2013-10-31 12:35 ` Laurent Pinchart
2013-11-13 15:15 ` Laurent Pinchart
2013-11-14 4:14 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131114041356.GB22870@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).