From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: Enable DSW2 with gpio-keys on KZM9D
Date: Thu, 14 Nov 2013 05:22:06 +0000 [thread overview]
Message-ID: <20131114052204.GD22870@verge.net.au> (raw)
In-Reply-To: <20131113230345.21482.36997.sendpatchset@w520>
On Thu, Nov 14, 2013 at 08:03:45AM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Use the gpio-keys driver to support the 4 pins on the
> dip switch DSW2 which is mounted on the KZM9D board.
>
> Signed-off-by: Magnus Damm <damm@opensource.se>
Hi Magnus,
I have tried enabling the following on a config produced
using the kzm9d_defconfig:
CONFIG_INPUT_KEYBOARD
CONFIG_INPUT_EVDEV
CONFIG_KEYBOARD_GPIO
But all I see so far in dmsg is:
# dmesg | grep gpio
platform gpio_keys.3: Driver gpio-keys requests probe deferral
I was expecting something more along the lines of:
input: gpio-keys as /devices/platform/gpio-keys/input/input0
Could you give me some guidance on how to test this?
> ---
>
> arch/arm/boot/dts/emev2-kzm9d.dts | 39 ++++++++++++++++++++++++++++++++++++-
> arch/arm/boot/dts/emev2.dtsi | 2 -
> 2 files changed, 39 insertions(+), 2 deletions(-)
>
> --- 0001/arch/arm/boot/dts/emev2-kzm9d.dts
> +++ work/arch/arm/boot/dts/emev2-kzm9d.dts 2013-11-13 20:21:27.000000000 +0900
> @@ -9,7 +9,9 @@
> */
> /dts-v1/;
>
> -/include/ "emev2.dtsi"
> +#include "emev2.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
>
> / {
> model = "EMEV2 KZM9D Board";
> @@ -54,4 +56,39 @@
> vddvario-supply = <®_1p8v>;
> vdd33a-supply = <®_3p3v>;
> };
> +
> + gpio_keys {
> + compatible = "gpio-keys";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + button@1 {
> + debounce_interval = <50>;
> + wakeup = <1>;
> + label = "DSW2-1";
> + linux,code = <KEY_1>;
> + gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
> + };
> + button@2 {
> + debounce_interval = <50>;
> + wakeup = <1>;
> + label = "DSW2-2";
> + linux,code = <KEY_2>;
> + gpios = <&gpio0 15 GPIO_ACTIVE_HIGH>;
> + };
> + button@3 {
> + debounce_interval = <50>;
> + wakeup = <1>;
> + label = "DSW2-3";
> + linux,code = <KEY_3>;
> + gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>;
> + };
> + button@4 {
> + debounce_interval = <50>;
> + wakeup = <1>;
> + label = "DSW2-4";
> + linux,code = <KEY_4>;
> + gpios = <&gpio0 17 GPIO_ACTIVE_HIGH>;
> + };
> + };
> };
> --- 0001/arch/arm/boot/dts/emev2.dtsi
> +++ work/arch/arm/boot/dts/emev2.dtsi 2013-11-13 20:20:03.000000000 +0900
> @@ -8,7 +8,7 @@
> * kind, whether express or implied.
> */
>
> -/include/ "skeleton.dtsi"
> +#include "skeleton.dtsi"
>
> / {
> compatible = "renesas,emev2";
>
next prev parent reply other threads:[~2013-11-14 5:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 23:03 [PATCH] ARM: shmobile: Enable DSW2 with gpio-keys on KZM9D Magnus Damm
2013-11-14 5:22 ` Simon Horman [this message]
2013-11-14 6:27 ` Simon Horman
2013-11-14 8:45 ` Magnus Damm
2013-11-19 2:33 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131114052204.GD22870@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).