[PATCH] ARM: shmobile: lager: mark GPIO keys as wake-up sources

[PATCH] ARM: shmobile: lager: mark GPIO keys as wake-up sources

[Magnus Damm]

From: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>

Enable wakeup for the GPIO keys on the Lager board.

Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
Signed-off-by: Magnus Damm <damm@opensource.se>
---

 arch/arm/mach-shmobile/board-lager.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- 0002/arch/arm/mach-shmobile/board-lager.c
+++ work/arch/arm/mach-shmobile/board-lager.c	2013-11-13 17:22:08.000000000 +0900
@@ -121,7 +121,7 @@ static const struct gpio_led_platform_da
 /* GPIO KEY */
 #define GPIO_KEY(c, g, d, ...) \
 	{ .code = c, .gpio = g, .desc = d, .active_low = 1, \
-	  .debounce_interval = 20 }
+	  .wakeup = 1, .debounce_interval = 20 }
 
 static struct gpio_keys_button gpio_buttons[] = {
 	GPIO_KEY(KEY_4,		RCAR_GP_PIN(1, 28),	"SW2-pin4"),

Re: [PATCH] ARM: shmobile: lager: mark GPIO keys as wake-up sources

[Simon Horman]

On Thu, Nov 14, 2013 at 07:40:26AM +0900, Magnus Damm wrote:
> From: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
> 
> Enable wakeup for the GPIO keys on the Lager board.
> 
> Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
> Signed-off-by: Magnus Damm <damm@opensource.se>

Hi Magnus,

is this relevant to other boards too?

> ---
> 
>  arch/arm/mach-shmobile/board-lager.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- 0002/arch/arm/mach-shmobile/board-lager.c
> +++ work/arch/arm/mach-shmobile/board-lager.c	2013-11-13 17:22:08.000000000 +0900
> @@ -121,7 +121,7 @@ static const struct gpio_led_platform_da
>  /* GPIO KEY */
>  #define GPIO_KEY(c, g, d, ...) \
>  	{ .code = c, .gpio = g, .desc = d, .active_low = 1, \
> -	  .debounce_interval = 20 }
> +	  .wakeup = 1, .debounce_interval = 20 }
>  
>  static struct gpio_keys_button gpio_buttons[] = {
>  	GPIO_KEY(KEY_4,		RCAR_GP_PIN(1, 28),	"SW2-pin4"),
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH] ARM: shmobile: lager: mark GPIO keys as wake-up sources

[Magnus Damm]

Hi Simon,

On Thu, Nov 14, 2013 at 3:26 PM, Simon Horman <horms@verge.net.au> wrote:
> On Thu, Nov 14, 2013 at 07:40:26AM +0900, Magnus Damm wrote:
>> From: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
>>
>> Enable wakeup for the GPIO keys on the Lager board.
>>
>> Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
>> Signed-off-by: Magnus Damm <damm@opensource.se>
>
> Hi Magnus,
>
> is this relevant to other boards too?

Yes, but I'd like to add the missing pieces for Suspend-to-RAM to
other SoCs too before trying to do that. If you want to give it a go,
why don't you try to enable it on r8a7779 and Marzen?

Thanks,

/ magnus

Re: [PATCH] ARM: shmobile: lager: mark GPIO keys as wake-up sources

[Simon Horman]

On Thu, Nov 14, 2013 at 07:40:26AM +0900, Magnus Damm wrote:
> From: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
> 
> Enable wakeup for the GPIO keys on the Lager board.
> 
> Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
> Signed-off-by: Magnus Damm <damm@opensource.se>

Thanks, I will queue this up.