From: Arnd Bergmann <arnd@arndb.de>
To: John Stultz <john.stultz@linaro.org>
Cc: Magnus Damm <magnus.damm@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
khilman@linaro.org, linux-sh@vger.kernel.org,
daniel.lezcano@linaro.org, horms@verge.net.au, olof@lixom.net,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2 01/03] clocksource: Add Kconfig entries for CMT, MTU2, TMU and STI
Date: Thu, 14 Nov 2013 12:40:37 +0000 [thread overview]
Message-ID: <201311141340.38208.arnd@arndb.de> (raw)
In-Reply-To: <CANcMJZDJPbctuYgG0Wr64htUeak-XLf3EYK0vz-BbG320UkFGg@mail.gmail.com>
On Wednesday 13 November 2013, John Stultz wrote:
> > +config EM_TIMER_STI
> > + bool "STI timer driver"
> > + default y if ARM
> > + help
> > + This enables build of the STI timer driver.
>
>
> So since I do want to avoid adding user-selectable configs if
> possible, here are some concrete thoughts on this patch, trying to
> provide an example from my more abstract rants down thread. :)
I think we should be using the CONFIG_BUILD_TEST (or whatever
it's called) here to allow building the drivers everywhere but
at the same time be specific with the platform. How about this:
config EM_TIMER_STI
bool "Renesas EMMA EV2 STI timer driver" if BUILD_TEST && !ARCH_EMEV2
default ARCH_EMEV2
help
...
This makes it a silent option that is set correctly all the time
but lets you enable it everywhere when BUILD_TEST is set.
We could skip the "&& !ARCH_EMEV2" part to allow building an
EMEV2 kernel without this driver when build testing if that
is possible.
Arnd
next prev parent reply other threads:[~2013-11-14 12:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 11:05 [PATCH v2 00/03] clocksource: Consolidate SH and ARM mach-shmobile Kconfig bits Magnus Damm
2013-11-06 11:05 ` [PATCH v2 01/03] clocksource: Add Kconfig entries for CMT, MTU2, TMU and STI Magnus Damm
2013-11-07 11:27 ` Daniel Lezcano
2013-11-08 8:23 ` Magnus Damm
2013-11-08 18:34 ` John Stultz
2013-11-12 12:26 ` Magnus Damm
2013-11-12 20:47 ` John Stultz
2013-11-13 21:14 ` Daniel Lezcano
2013-11-13 21:25 ` John Stultz
2013-11-28 5:42 ` Magnus Damm
2013-12-02 23:08 ` John Stultz
2013-12-04 13:30 ` Magnus Damm
2013-11-13 21:38 ` John Stultz
2013-11-14 12:40 ` Arnd Bergmann [this message]
2013-11-20 8:33 ` Daniel Lezcano
2013-11-20 18:31 ` John Stultz
2013-11-20 19:34 ` Arnd Bergmann
2013-11-20 19:53 ` John Stultz
2013-11-06 11:05 ` [PATCH v2 02/03] ARM: shmobile: Remove CMT, TMU and STI Kconfig entries Magnus Damm
2013-11-06 11:05 ` [PATCH v2 03/03] sh: Remove Kconfig entries for TMU, CMT and MTU2 Magnus Damm
2013-11-06 22:20 ` [PATCH v2 00/03] clocksource: Consolidate SH and ARM mach-shmobile Kconfig bits Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201311141340.38208.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=horms@verge.net.au \
--cc=john.stultz@linaro.org \
--cc=khilman@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=olof@lixom.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).