linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: Use ->init_late() on Lager
Date: Tue, 19 Nov 2013 03:32:33 +0000	[thread overview]
Message-ID: <20131119033231.GB30900@verge.net.au> (raw)
In-Reply-To: <20131118085953.GF1506@verge.net.au>

On Mon, Nov 18, 2013 at 05:59:55PM +0900, Simon Horman wrote:
> On Thu, Nov 14, 2013 at 07:34:06AM +0900, Magnus Damm wrote:
> > From: Magnus Damm <damm@opensource.se>
> > 
> > Hook in shmobile_init_late() on Lager. This enables some PM
> > related things like CPUIdle and Suspend-to-RAM.
> > 
> > With this patch applied it is possible to use Suspend-to-RAM:
> > # echo enabled > /sys/class/tty/ttySC6/power/wakeup
> > # echo mem > /sys/power/state 
> > (wake by sending a character on the serial console)
> > 
> > Signed-off-by: Magnus Damm <damm@opensource.se>
> 
> Thanks, I will queue this up.

Hi Magnus,

it seems that this patch needs the following so that shmobile_init_late
is defined. I am dropping this patch for now.

diff --git a/arch/arm/mach-shmobile/board-lager-reference.c b/arch/arm/mach-shmobile/board-lager-reference.c
index ac01118..51a3bcc 100644
--- a/arch/arm/mach-shmobile/board-lager-reference.c
+++ b/arch/arm/mach-shmobile/board-lager-reference.c
@@ -20,6 +20,7 @@
 
 #include <linux/init.h>
 #include <linux/of_platform.h>
+#include <mach/common.h>
 #include <mach/rcar-gen2.h>
 #include <mach/r8a7790.h>
 #include <asm/mach/arch.h>



  reply	other threads:[~2013-11-19  3:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-13 22:34 [PATCH] ARM: shmobile: Use ->init_late() on Lager Magnus Damm
2013-11-18  8:59 ` Simon Horman
2013-11-19  3:32   ` Simon Horman [this message]
2013-11-20  3:54 ` [PATCH] ARM: shmobile: Use ->init_late() on Koelsch Magnus Damm
2013-11-21  3:59   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131119033231.GB30900@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).