From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] ARM: shmobile: Use ->init_late() on Lager
Date: Thu, 21 Nov 2013 06:58:23 +0000 [thread overview]
Message-ID: <20131121065821.GA4753@verge.net.au> (raw)
In-Reply-To: <20131121045536.GT31130@verge.net.au>
On Thu, Nov 21, 2013 at 01:55:37PM +0900, Simon Horman wrote:
> On Wed, Nov 20, 2013 at 09:02:31AM +0900, Magnus Damm wrote:
> > From: Magnus Damm <damm@opensource.se>
> >
> > Hook in shmobile_init_late() on Lager V2. This enables some PM
> > related things like CPUIdle and Suspend-to-RAM.
> >
> > With this patch applied it is possible to use Suspend-to-RAM:
> > # echo enabled > /sys/class/tty/ttySC6/power/wakeup
> > # echo mem > /sys/power/state
> > (wake by sending a character on the serial console)
> >
> > Signed-off-by: Magnus Damm <damm@opensource.se>
> > ---
> >
> > Changes since V1:
> > - added missing include <mach/common.h> to DT reference code
> >
> > Written on top of renesas.git renesas-devel-v3.12-20131119
> >
> > arch/arm/mach-shmobile/board-lager-reference.c | 2 ++
> > arch/arm/mach-shmobile/board-lager.c | 1 +
> > 2 files changed, 3 insertions(+)
> >
> > --- 0001/arch/arm/mach-shmobile/board-lager-reference.c
> > +++ work/arch/arm/mach-shmobile/board-lager-reference.c 2013-11-20 08:14:45.000000000 +0900
> > @@ -20,6 +20,7 @@
> >
> > #include <linux/init.h>
> > #include <linux/of_platform.h>
> > +#include <mach/common.h>
> > #include <mach/rcar-gen2.h>
> > #include <mach/r8a7790.h>
> > #include <asm/mach/arch.h>
> > @@ -41,5 +42,6 @@ DT_MACHINE_START(LAGER_DT, "lager")
> > .init_early = r8a7790_init_early,
> > .init_time = rcar_gen2_timer_init,
> > .init_machine = lager_add_standard_devices,
> > + .init_late = shmobile_init_late,
> > .dt_compat = lager_boards_compat_dt,
> > MACHINE_END
> > --- 0001/arch/arm/mach-shmobile/board-lager.c
> > +++ work/arch/arm/mach-shmobile/board-lager.c 2013-11-20 08:14:34.000000000 +0900
> > @@ -259,5 +259,6 @@ DT_MACHINE_START(LAGER_DT, "lager")
> > .init_early = r8a7790_init_early,
> > .init_time = rcar_gen2_timer_init,
> > .init_machine = lager_init,
> > + .init_late = shmobile_init_late,
> > .dt_compat = lager_boards_compat_dt,
> > MACHINE_END
>
>
> Thanks. I have manually applied the following onto the soc3 branch.
> Please check that it is correct.
>
> Assuming all goes will I plan to push this and other updates
> today or tomorrow.
Take II: I have applied your patch as is without any manual intervention.
prev parent reply other threads:[~2013-11-21 6:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 0:02 [PATCH v2] ARM: shmobile: Use ->init_late() on Lager Magnus Damm
2013-11-21 4:55 ` Simon Horman
2013-11-21 6:58 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131121065821.GA4753@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).