From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] ARM: shmobile: Fix r8a7790 GPIO resources in DTS
Date: Mon, 25 Nov 2013 02:50:33 +0000 [thread overview]
Message-ID: <20131125025033.GD2786@verge.net.au> (raw)
In-Reply-To: <20131125024008.GA813@verge.net.au>
On Mon, Nov 25, 2013 at 11:40:08AM +0900, Simon Horman wrote:
> On Thu, Nov 21, 2013 at 09:29:49AM +0100, Laurent Pinchart wrote:
> > Hi Magnus,
> >
> > Thank you for the patch.
> >
> > On Thursday 21 November 2013 14:19:29 Magnus Damm wrote:
> > > From: Magnus Damm <damm@opensource.se>
> > >
> > > The r8a7790 GPIO resources are currently incorrect. Fix that
> > > by making them match the English r8a7790 v0.6 data sheet.
> > >
> > > Tested with GPIO LED using Lager DT reference.
> > >
> > > Signed-off-by: Magnus Damm <damm@opensource.se>
> >
> > Just before I go and hide for such an obvious mistake,
> >
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > :-)
>
> Hi, I would like to queue this up as a fix for v3.12 with the following
> amended changelog.
s/12/13/
>
> I would also like to take this opportunity state that my preferred
> subject format is: ARM: shmobile: soc or board: description
>
> Could you cook up something similar for the r8a7791 variant of this patch?
>
>
> [PATCH v2] ARM: shmobile: r8a7790: Fix GPIO resources in DTS
>
> From: Magnus Damm <damm@opensource.se>
>
> The r8a7790 GPIO resources are currently incorrect. Fix that
> by making them match the English r8a7790 v0.6 data sheet.
>
> Tested with GPIO LED using Lager DT reference.
>
> This problem has been present since GPIOs were added to the r8a7790 SoC by
> f98e10c88aa95bf7 ("ARM: shmobile: r8a7790: Add GPIO controller devices to
> device tree") in v3.12-rc1.
>
> Signed-off-by: Magnus Damm <damm@opensource.se>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
next prev parent reply other threads:[~2013-11-25 2:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 5:19 [PATCH v2] ARM: shmobile: Fix r8a7790 GPIO resources in DTS Magnus Damm
2013-11-21 8:29 ` Laurent Pinchart
2013-11-25 2:40 ` Simon Horman
2013-11-25 2:50 ` Simon Horman [this message]
2013-11-28 8:05 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131125025033.GD2786@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).