* [PATCH 01/04] ARM: shmobile: Use sh73a0 suffix for INTC compat string
2013-11-27 23:14 [PATCH 00/04] ARM: shmobile: Use SoC suffix for INTC compat string Magnus Damm
@ 2013-11-27 23:14 ` Magnus Damm
2013-11-27 23:15 ` [PATCH 02/04] ARM: shmobile: Use r8a7740 " Magnus Damm
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Magnus Damm @ 2013-11-27 23:14 UTC (permalink / raw)
To: linux-arm-kernel
From: Magnus Damm <damm@opensource.se>
Add "renesas,intc-irqpin-sh73a0" to the compatible string for the
IRQ pins in case of sh73a0 INTC. This makes the INTC irqpin follow
the same style as the other devices and also makes it more future proof.
Signed-off-by: Magnus Damm <damm@opensource.se>
---
arch/arm/boot/dts/sh73a0.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- 0001/arch/arm/boot/dts/sh73a0.dtsi
+++ work/arch/arm/boot/dts/sh73a0.dtsi 2013-11-28 07:38:21.000000000 +0900
@@ -47,7 +47,7 @@
};
irqpin0: irqpin@e6900000 {
- compatible = "renesas,intc-irqpin";
+ compatible = "renesas,intc-irqpin-sh73a0", "renesas,intc-irqpin";
#interrupt-cells = <2>;
interrupt-controller;
reg = <0xe6900000 4>,
@@ -67,7 +67,7 @@
};
irqpin1: irqpin@e6900004 {
- compatible = "renesas,intc-irqpin";
+ compatible = "renesas,intc-irqpin-sh73a0", "renesas,intc-irqpin";
#interrupt-cells = <2>;
interrupt-controller;
reg = <0xe6900004 4>,
@@ -88,7 +88,7 @@
};
irqpin2: irqpin@e6900008 {
- compatible = "renesas,intc-irqpin";
+ compatible = "renesas,intc-irqpin-sh73a0", "renesas,intc-irqpin";
#interrupt-cells = <2>;
interrupt-controller;
reg = <0xe6900008 4>,
@@ -108,7 +108,7 @@
};
irqpin3: irqpin@e690000c {
- compatible = "renesas,intc-irqpin";
+ compatible = "renesas,intc-irqpin-sh73a0", "renesas,intc-irqpin";
#interrupt-cells = <2>;
interrupt-controller;
reg = <0xe690000c 4>,
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH 02/04] ARM: shmobile: Use r8a7740 suffix for INTC compat string
2013-11-27 23:14 [PATCH 00/04] ARM: shmobile: Use SoC suffix for INTC compat string Magnus Damm
2013-11-27 23:14 ` [PATCH 01/04] ARM: shmobile: Use sh73a0 " Magnus Damm
@ 2013-11-27 23:15 ` Magnus Damm
2013-11-27 23:15 ` [PATCH 03/04] ARM: shmobile: Use r8a7778 " Magnus Damm
` (2 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Magnus Damm @ 2013-11-27 23:15 UTC (permalink / raw)
To: linux-arm-kernel
From: Magnus Damm <damm@opensource.se>
Add "renesas,intc-irqpin-r8a7740" to the compatible string for the
IRQ pins in case of r8a7740 INTC. This makes the INTC irqpin follow
the same style as the other devices and also makes it more future proof.
Signed-off-by: Magnus Damm <damm@opensource.se>
---
arch/arm/boot/dts/r8a7740.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- 0001/arch/arm/boot/dts/r8a7740.dtsi
+++ work/arch/arm/boot/dts/r8a7740.dtsi 2013-11-28 07:35:58.000000000 +0900
@@ -41,7 +41,7 @@
/* irqpin0: IRQ0 - IRQ7 */
irqpin0: irqpin@e6900000 {
- compatible = "renesas,intc-irqpin";
+ compatible = "renesas,intc-irqpin-r8a7740", "renesas,intc-irqpin";
#interrupt-cells = <2>;
interrupt-controller;
reg = <0xe6900000 4>,
@@ -62,7 +62,7 @@
/* irqpin1: IRQ8 - IRQ15 */
irqpin1: irqpin@e6900004 {
- compatible = "renesas,intc-irqpin";
+ compatible = "renesas,intc-irqpin-r8a7740", "renesas,intc-irqpin";
#interrupt-cells = <2>;
interrupt-controller;
reg = <0xe6900004 4>,
@@ -83,7 +83,7 @@
/* irqpin2: IRQ16 - IRQ23 */
irqpin2: irqpin@e6900008 {
- compatible = "renesas,intc-irqpin";
+ compatible = "renesas,intc-irqpin-r8a7740", "renesas,intc-irqpin";
#interrupt-cells = <2>;
interrupt-controller;
reg = <0xe6900008 4>,
@@ -104,7 +104,7 @@
/* irqpin3: IRQ24 - IRQ31 */
irqpin3: irqpin@e690000c {
- compatible = "renesas,intc-irqpin";
+ compatible = "renesas,intc-irqpin-r8a7740", "renesas,intc-irqpin";
#interrupt-cells = <2>;
interrupt-controller;
reg = <0xe690000c 4>,
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH 03/04] ARM: shmobile: Use r8a7778 suffix for INTC compat string
2013-11-27 23:14 [PATCH 00/04] ARM: shmobile: Use SoC suffix for INTC compat string Magnus Damm
2013-11-27 23:14 ` [PATCH 01/04] ARM: shmobile: Use sh73a0 " Magnus Damm
2013-11-27 23:15 ` [PATCH 02/04] ARM: shmobile: Use r8a7740 " Magnus Damm
@ 2013-11-27 23:15 ` Magnus Damm
2013-11-27 23:15 ` [PATCH 04/04] ARM: shmobile: Use r8a7779 " Magnus Damm
2013-11-28 6:45 ` [PATCH 00/04] ARM: shmobile: Use SoC " Simon Horman
4 siblings, 0 replies; 9+ messages in thread
From: Magnus Damm @ 2013-11-27 23:15 UTC (permalink / raw)
To: linux-arm-kernel
From: Magnus Damm <damm@opensource.se>
Add "renesas,intc-irqpin-r8a7778" to the compatible string for the
IRQ pins in case of r8a7778 INTC. This makes the INTC irqpin follow
the same style as the other devices and also makes it more future proof.
Signed-off-by: Magnus Damm <damm@opensource.se>
---
arch/arm/boot/dts/r8a7778.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 0001/arch/arm/boot/dts/r8a7778.dtsi
+++ work/arch/arm/boot/dts/r8a7778.dtsi 2013-11-28 07:41:06.000000000 +0900
@@ -43,7 +43,7 @@
/* irqpin: IRQ0 - IRQ3 */
irqpin: irqpin@fe78001c {
- compatible = "renesas,intc-irqpin";
+ compatible = "renesas,intc-irqpin-r8a7778", "renesas,intc-irqpin";
#interrupt-cells = <2>;
interrupt-controller;
status = "disabled"; /* default off */
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH 04/04] ARM: shmobile: Use r8a7779 suffix for INTC compat string
2013-11-27 23:14 [PATCH 00/04] ARM: shmobile: Use SoC suffix for INTC compat string Magnus Damm
` (2 preceding siblings ...)
2013-11-27 23:15 ` [PATCH 03/04] ARM: shmobile: Use r8a7778 " Magnus Damm
@ 2013-11-27 23:15 ` Magnus Damm
2013-11-28 6:45 ` [PATCH 00/04] ARM: shmobile: Use SoC " Simon Horman
4 siblings, 0 replies; 9+ messages in thread
From: Magnus Damm @ 2013-11-27 23:15 UTC (permalink / raw)
To: linux-arm-kernel
From: Magnus Damm <damm@opensource.se>
Add "renesas,intc-irqpin-r8a7779" to the compatible string for the
IRQ pins in case of r8a7779 INTC. This makes the INTC irqpin follow
the same style as the other devices and also makes it more future proof.
Signed-off-by: Magnus Damm <damm@opensource.se>
---
arch/arm/boot/dts/r8a7779.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 0001/arch/arm/boot/dts/r8a7779.dtsi
+++ work/arch/arm/boot/dts/r8a7779.dtsi 2013-11-28 07:42:50.000000000 +0900
@@ -135,7 +135,7 @@
};
irqpin0: irqpin@fe780010 {
- compatible = "renesas,intc-irqpin";
+ compatible = "renesas,intc-irqpin-r8a7779", "renesas,intc-irqpin";
#interrupt-cells = <2>;
status = "disabled";
interrupt-controller;
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 00/04] ARM: shmobile: Use SoC suffix for INTC compat string
2013-11-27 23:14 [PATCH 00/04] ARM: shmobile: Use SoC suffix for INTC compat string Magnus Damm
` (3 preceding siblings ...)
2013-11-27 23:15 ` [PATCH 04/04] ARM: shmobile: Use r8a7779 " Magnus Damm
@ 2013-11-28 6:45 ` Simon Horman
2013-12-04 19:21 ` Magnus Damm
4 siblings, 1 reply; 9+ messages in thread
From: Simon Horman @ 2013-11-28 6:45 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Nov 28, 2013 at 08:14:50AM +0900, Magnus Damm wrote:
> ARM: shmobile: Use SoC suffix for INTC compat string
>
> [PATCH 01/04] ARM: shmobile: Use sh73a0 suffix for INTC compat string
> [PATCH 02/04] ARM: shmobile: Use r8a7740 suffix for INTC compat string
> [PATCH 03/04] ARM: shmobile: Use r8a7778 suffix for INTC compat string
> [PATCH 04/04] ARM: shmobile: Use r8a7779 suffix for INTC compat string
>
> Update the DTS for INTC irqpin devices to include the SoC in the compat string.
>
> Both IRQC and INTC irqpin need documentation for the DT bindings, and this
> will happen in incremental patches.
I have posted some patches for that a few moments ago :)
I am curious to if it is intentional that this series replaces
the use of less-specific compat strings with more specific ones
while the recent update to the r8a7790 supplemented the
less-specific renesas,irqc comat string with the more-specific
renesas,irqc-r8a7790 compat string.
i.e.
before: "renesas,intc-irqpin"
after: "renesas,intc-irqpin-sh73a0"
as opposed to
before: "renesas,irqc"
after: "renesas,irqc-r8a7790", "renesas,irqc"
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 00/04] ARM: shmobile: Use SoC suffix for INTC compat string
2013-11-28 6:45 ` [PATCH 00/04] ARM: shmobile: Use SoC " Simon Horman
@ 2013-12-04 19:21 ` Magnus Damm
2013-12-05 2:50 ` Simon Horman
0 siblings, 1 reply; 9+ messages in thread
From: Magnus Damm @ 2013-12-04 19:21 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Nov 28, 2013 at 7:45 AM, Simon Horman <horms@verge.net.au> wrote:
> On Thu, Nov 28, 2013 at 08:14:50AM +0900, Magnus Damm wrote:
>> ARM: shmobile: Use SoC suffix for INTC compat string
>>
>> [PATCH 01/04] ARM: shmobile: Use sh73a0 suffix for INTC compat string
>> [PATCH 02/04] ARM: shmobile: Use r8a7740 suffix for INTC compat string
>> [PATCH 03/04] ARM: shmobile: Use r8a7778 suffix for INTC compat string
>> [PATCH 04/04] ARM: shmobile: Use r8a7779 suffix for INTC compat string
>>
>> Update the DTS for INTC irqpin devices to include the SoC in the compat string.
>>
>> Both IRQC and INTC irqpin need documentation for the DT bindings, and this
>> will happen in incremental patches.
>
> I have posted some patches for that a few moments ago :)
Thanks for that!
> I am curious to if it is intentional that this series replaces
> the use of less-specific compat strings with more specific ones
> while the recent update to the r8a7790 supplemented the
> less-specific renesas,irqc comat string with the more-specific
> renesas,irqc-r8a7790 compat string.
>
> i.e.
> before: "renesas,intc-irqpin"
> after: "renesas,intc-irqpin-sh73a0"
>
> as opposed to
>
> before: "renesas,irqc"
> after: "renesas,irqc-r8a7790", "renesas,irqc"
My intention is to keep them the same. I just checked the intc-irqpin
patches but they seem to be following the same style as IRQC. On which
SoC did you observe this difference?
Thanks,
/ magnus
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 00/04] ARM: shmobile: Use SoC suffix for INTC compat string
2013-12-04 19:21 ` Magnus Damm
@ 2013-12-05 2:50 ` Simon Horman
2013-12-05 5:17 ` Simon Horman
0 siblings, 1 reply; 9+ messages in thread
From: Simon Horman @ 2013-12-05 2:50 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Dec 04, 2013 at 08:21:42PM +0100, Magnus Damm wrote:
> On Thu, Nov 28, 2013 at 7:45 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Thu, Nov 28, 2013 at 08:14:50AM +0900, Magnus Damm wrote:
> >> ARM: shmobile: Use SoC suffix for INTC compat string
> >>
> >> [PATCH 01/04] ARM: shmobile: Use sh73a0 suffix for INTC compat string
> >> [PATCH 02/04] ARM: shmobile: Use r8a7740 suffix for INTC compat string
> >> [PATCH 03/04] ARM: shmobile: Use r8a7778 suffix for INTC compat string
> >> [PATCH 04/04] ARM: shmobile: Use r8a7779 suffix for INTC compat string
> >>
> >> Update the DTS for INTC irqpin devices to include the SoC in the compat string.
> >>
> >> Both IRQC and INTC irqpin need documentation for the DT bindings, and this
> >> will happen in incremental patches.
> >
> > I have posted some patches for that a few moments ago :)
>
> Thanks for that!
>
> > I am curious to if it is intentional that this series replaces
> > the use of less-specific compat strings with more specific ones
> > while the recent update to the r8a7790 supplemented the
> > less-specific renesas,irqc comat string with the more-specific
> > renesas,irqc-r8a7790 compat string.
> >
> > i.e.
> > before: "renesas,intc-irqpin"
> > after: "renesas,intc-irqpin-sh73a0"
> >
> > as opposed to
> >
> > before: "renesas,irqc"
> > after: "renesas,irqc-r8a7790", "renesas,irqc"
>
> My intention is to keep them the same. I just checked the intc-irqpin
> patches but they seem to be following the same style as IRQC. On which
> SoC did you observe this difference?
Sorry, ignore this. I was confused.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 00/04] ARM: shmobile: Use SoC suffix for INTC compat string
2013-12-05 2:50 ` Simon Horman
@ 2013-12-05 5:17 ` Simon Horman
0 siblings, 0 replies; 9+ messages in thread
From: Simon Horman @ 2013-12-05 5:17 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Dec 05, 2013 at 11:50:04AM +0900, Simon Horman wrote:
> On Wed, Dec 04, 2013 at 08:21:42PM +0100, Magnus Damm wrote:
> > On Thu, Nov 28, 2013 at 7:45 AM, Simon Horman <horms@verge.net.au> wrote:
> > > On Thu, Nov 28, 2013 at 08:14:50AM +0900, Magnus Damm wrote:
> > >> ARM: shmobile: Use SoC suffix for INTC compat string
> > >>
> > >> [PATCH 01/04] ARM: shmobile: Use sh73a0 suffix for INTC compat string
> > >> [PATCH 02/04] ARM: shmobile: Use r8a7740 suffix for INTC compat string
> > >> [PATCH 03/04] ARM: shmobile: Use r8a7778 suffix for INTC compat string
> > >> [PATCH 04/04] ARM: shmobile: Use r8a7779 suffix for INTC compat string
> > >>
> > >> Update the DTS for INTC irqpin devices to include the SoC in the compat string.
> > >>
> > >> Both IRQC and INTC irqpin need documentation for the DT bindings, and this
> > >> will happen in incremental patches.
> > >
> > > I have posted some patches for that a few moments ago :)
> >
> > Thanks for that!
> >
> > > I am curious to if it is intentional that this series replaces
> > > the use of less-specific compat strings with more specific ones
> > > while the recent update to the r8a7790 supplemented the
> > > less-specific renesas,irqc comat string with the more-specific
> > > renesas,irqc-r8a7790 compat string.
> > >
> > > i.e.
> > > before: "renesas,intc-irqpin"
> > > after: "renesas,intc-irqpin-sh73a0"
> > >
> > > as opposed to
> > >
> > > before: "renesas,irqc"
> > > after: "renesas,irqc-r8a7790", "renesas,irqc"
> >
> > My intention is to keep them the same. I just checked the intc-irqpin
> > patches but they seem to be following the same style as IRQC. On which
> > SoC did you observe this difference?
>
> Sorry, ignore this. I was confused.
Now that I am not longer confused I will queue up these patches.
^ permalink raw reply [flat|nested] 9+ messages in thread