From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: lager: Constify lager_boards_compat_dt
Date: Thu, 28 Nov 2013 02:22:41 +0000 [thread overview]
Message-ID: <20131128022241.GC22413@verge.net.au> (raw)
In-Reply-To: <528F5EC9.9000203@cogentembedded.com>
On Fri, Nov 22, 2013 at 05:40:25PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 22-11-2013 5:02, Simon Horman wrote:
>
> >lager_boards_compat_dt is kmemdup()ed when the corresponding devices are
> >registered and can thus be declared as const. Do so.
>
> >This replicates a portion of 27113d63daac0aac ("ARM: shmobile: lager:
> >Constify platform data and resources") which appears to have inadvertently
> >been lost during merging.
>
> >Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >---
> > arch/arm/mach-shmobile/board-lager.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> >diff --git a/arch/arm/mach-shmobile/board-lager.c b/arch/arm/mach-shmobile/board-lager.c
> >index d47052e..04c5ca8 100644
> >--- a/arch/arm/mach-shmobile/board-lager.c
> >+++ b/arch/arm/mach-shmobile/board-lager.c
> >@@ -249,7 +249,7 @@ static void __init lager_init(void)
> > phy_register_fixup_for_id("r8a7790-ether-ff:01", lager_ksz8041_fixup);
> > }
> >
> >-static const char * const lager_boards_compat_dt[] __initconst = {
> >+static const char *lager_boards_compat_dt[] __initdata = {
> > "renesas,lager",
> > NULL,
>
> But aren't you in fact reverting the described change?
Yes. This patch is completely bogus.
prev parent reply other threads:[~2013-11-28 2:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 1:02 [PATCH] ARM: shmobile: lager: Constify lager_boards_compat_dt Simon Horman
2013-11-22 13:40 ` Sergei Shtylyov
2013-11-28 2:22 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131128022241.GC22413@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).