From: Mark Brown <broonie@kernel.org>
To: Laurent Pinchart
<laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
Cc: linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] spi: sh-msiof: Convert to clk_prepare/unprepare
Date: Thu, 28 Nov 2013 10:34:07 +0000 [thread overview]
Message-ID: <20131128103407.GI14725@sirena.org.uk> (raw)
In-Reply-To: <1385602783-3439-2-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 710 bytes --]
On Thu, Nov 28, 2013 at 02:39:43AM +0100, Laurent Pinchart wrote:
> Get the driver ready for the migration to the common clock framework by
> calling clk_prepare() and clk_unprepare(). The calls are added in the
> probe and remove handlers as the clk_enable() and clk_disable() calls
> are located in atomic context and there's no callback function in
> non-atomic context that can be used to prepare/unprepare the clock.
Applied, thanks. However it does seem like you should be able to move
the prepare and disable to runtime PM rather than leaving it prepared
for the entire time the driver is loaded. In most systems this won't
make any difference since prepare won't do anything but it's a bit
neater.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-11-28 10:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 1:39 [PATCH 1/2] spi: sh-msiof: Use devm_* managed allocators Laurent Pinchart
[not found] ` <1385602783-3439-1-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2013-11-28 1:39 ` [PATCH 2/2] spi: sh-msiof: Convert to clk_prepare/unprepare Laurent Pinchart
[not found] ` <1385602783-3439-2-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2013-11-28 10:34 ` Mark Brown [this message]
[not found] ` <20131128103407.GI14725-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-11-28 14:16 ` Laurent Pinchart
2013-11-28 16:44 ` Mark Brown
2013-11-28 10:27 ` [PATCH 1/2] spi: sh-msiof: Use devm_* managed allocators Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131128103407.GI14725@sirena.org.uk \
--to=broonie@kernel.org \
--cc=laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).