From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Date: Mon, 02 Dec 2013 12:53:20 +0000 Subject: Re: [PATCH 03/11] spi: spi-sh-msiof: let it run even without GPIO Message-Id: <20131202125320.GD27568@sirena.org.uk> MIME-Version: 1 Content-Type: multipart/mixed; boundary="DYCP9ZX4RRtQiwKl" List-Id: References: <20131202031557.162e78d407d82effdee627ac@ops.dti.ne.jp> <1385921962-19843-1-git-send-email-takasi-y@ops.dti.ne.jp> <1385921962-19843-3-git-send-email-takasi-y@ops.dti.ne.jp> In-Reply-To: <1385921962-19843-3-git-send-email-takasi-y-nDL5PR/MsHhHfZP73Gtkiw@public.gmane.org> To: takasi-y-nDL5PR/MsHhHfZP73Gtkiw@public.gmane.org Cc: linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Simon Horman , Magnus Damm , Linus Walleij , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org --DYCP9ZX4RRtQiwKl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 02, 2013 at 03:19:14AM +0900, takasi-y@ops.dti.ne.jp wrote: > - /* use spi->controller data for CS (same strategy as spi_gpio) */ > - gpio_set_value((unsigned)spi->controller_data, value); > + /* use spi->controller data for CS (same strategy as spi_gpio), > + * if any. otherwise let HW controll CS */ > + if (spi->controller_data) > + gpio_set_value((unsigned)spi->controller_data, value); This makes sense in terms of what it tries to do however the standard thing is to set the GPIO value to an error value if it isn't there (especially since 0 is in theory a valid GPIO) so the test should be different. I'd also suggest changing to use the core cs_gpio field but that's a separate thing. --DYCP9ZX4RRtQiwKl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSnIK9AAoJELSic+t+oim97LUP/2wxHJrMeaCTZ5a3Rp9qSr+g 59rH+xuCJDNIjfoaAnZSfStwhdn0u+J9CqFwByCb/H9fbGIgrzrSuAXyGcMPXvGQ Z9m+f9dOgKM/FLDeI8HXDuYg1q9s5AXBLqJBj5BC9u8junNmjQMyDocdCEcu0KKX b6KEfhREdfn6FH0++L/DbCN839MNKUBFFwvmPJhRffXxGz/tpxhPV34bg5aWspko UQU+8tryqoX3ptYARrVeIsGx9ceuKqW+de/70FrqaI0hOXULc6kU6eOxoOLE0K+M 0aFaqsbcwdomlYWSgK2Ls4Vubf/hz/PLt/GlouZW6iOVl0Znf75KGrHH1KRo7Uqu xSBwuEjfg0fZ7UUlPiTaiAFMBKOKpMvOoMUmvr/MHzgzGvJrGVZ+1X0aGPkMBsE1 TaMqqL5UYfMEETjAsJw/0LyggzAcgPdp42Fdpeg+hgy4iDMdqlBGF8Et8SjjoYsP 3GfOjw2iNMBUOkq5WJUTUvJAKgxhrUEizDJmi7Mt6higDl31REypfxYrqywSmST0 34YJjp++H2FhKJaL2WlKA4oFXBp8a5Y6Saa4eV13QmyiXSzuNhZlUWd0rl5QMKQW p1hcQzTH+/iOoCFBcBOVtSu86Dy5TxD7axba5LXyFxqY6fWLJ0jzEOhGm+BTBFAN 4Fx2ALTtEKkWsenA6Kcg =fhW5 -----END PGP SIGNATURE----- --DYCP9ZX4RRtQiwKl--