From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2] sh-pfc: r8a7740: Fix pin bias setup
Date: Thu, 05 Dec 2013 03:43:11 +0000 [thread overview]
Message-ID: <20131205034311.GA20388@verge.net.au> (raw)
In-Reply-To: <1385652004-7117-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
Hi Laurent,
On Thu, Nov 28, 2013 at 04:20:03PM +0100, Laurent Pinchart wrote:
> When computing the pin configuration register offset the bias setup code
> erroneously compares the pin number range with the loop index instead of
> the pin number. Fix it.
this appears to be a bug-fix. If you haven't queued this up already
could you consider adding something like this to the changelog?
Likewise for "[2/2] sh-pfc: sh7372: Fix pin bias setup".
This resolves a problem that was added when bias pinconf support was added
by 80da8e02d22caaef ("sh-pfc: r8a7740: Add bias (pull-up/down) pinconf
support") in v3.10-rc3.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/pinctrl/sh-pfc/pfc-r8a7740.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7740.c b/drivers/pinctrl/sh-pfc/pfc-r8a7740.c
> index 009174d..bc5eb45 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7740.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7740.c
> @@ -3720,7 +3720,7 @@ static void __iomem *r8a7740_pinmux_portcr(struct sh_pfc *pfc, unsigned int pin)
> const struct r8a7740_portcr_group *group > &r8a7740_portcr_offsets[i];
>
> - if (i <= group->end_pin)
> + if (pin <= group->end_pin)
> return pfc->window->virt + group->offset + pin;
> }
>
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-12-05 3:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 15:20 [PATCH 1/2] sh-pfc: r8a7740: Fix pin bias setup Laurent Pinchart
2013-12-05 3:43 ` Simon Horman [this message]
2013-12-05 5:55 ` Laurent Pinchart
2013-12-05 6:55 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131205034311.GA20388@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).