From: Mark Brown <broonie@kernel.org>
To: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
Cc: linux-spi@vger.kernel.org, linux-sh@vger.kernel.org,
Hiep Cao Minh <cm-hiep@jinso.co.jp>
Subject: Re: [PATCH 1/2] spi: rspi: Fix NULL pointer dereference on SH7757
Date: Tue, 24 Dec 2013 13:12:30 +0000 [thread overview]
Message-ID: <20131224131230.GE30815@sirena.org.uk> (raw)
In-Reply-To: <1387823664-32318-1-git-send-email-geert+renesas@linux-m68k.org>
On Mon, Dec 23, 2013 at 07:34:23PM +0100, Geert Uytterhoeven wrote:
> SH7757 doesn't pass platform data, in which case spi-rspi uses default
> parameters.
>
> However, commit 5ce0ba88650f2606244a761d92e2b725f4ab3583 ("spi: rcar: add
> Renesas QSPI support on RSPI") added a new user of the platform data, but
> forgot to check for its validity first, causing a NULL pointer dereference
> on SH7757.
Applied both, thanks.
prev parent reply other threads:[~2013-12-24 13:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 18:34 [PATCH 1/2] spi: rspi: Fix NULL pointer dereference on SH7757 Geert Uytterhoeven
2013-12-23 18:34 ` [PATCH 2/2] spi: rspi: Fix typo when clearing SPSR_OVRF Geert Uytterhoeven
[not found] ` <1387823664-32318-2-git-send-email-geert+renesas-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2013-12-24 2:59 ` Simon Horman
2013-12-24 9:26 ` Geert Uytterhoeven
[not found] ` <CAMuHMdWiJPF2NU+ME=CLMygvABZ_fcTyr7ggdQtFKbOGhCA0+w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-27 2:16 ` Simon Horman
[not found] ` <20131227021639.GD9184-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2014-01-09 9:41 ` Geert Uytterhoeven
[not found] ` <CAMuHMdU+4qCc64CkJeLAhh4SHqbB0E8Cu=8dKpmaYbphTBJV6g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-01-10 0:49 ` Simon Horman
2013-12-24 2:58 ` [PATCH 1/2] spi: rspi: Fix NULL pointer dereference on SH7757 Simon Horman
2013-12-24 13:12 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131224131230.GE30815@sirena.org.uk \
--to=broonie@kernel.org \
--cc=cm-hiep@jinso.co.jp \
--cc=geert+renesas@linux-m68k.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox