From: Mark Brown <broonie@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Geert Uytterhoeven <geert+renesas@linux-m68k.org>,
linux-spi@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH 4/5] spi: rspi: Use DUMMY_DATA macro instead of hardcoded value
Date: Mon, 30 Dec 2013 11:54:20 +0000 [thread overview]
Message-ID: <20131230115420.GI31886@sirena.org.uk> (raw)
In-Reply-To: <51418828.lCh7RnWjxA@avalon>
[-- Attachment #1: Type: text/plain, Size: 424 bytes --]
On Fri, Dec 27, 2013 at 03:36:12PM +0100, Laurent Pinchart wrote:
> On Tuesday 24 December 2013 10:49:33 Geert Uytterhoeven wrote:
> > /* dummy write for generate clock */
> > - rspi_write16(rspi, 0x00, RSPI_SPDR);
> > + rspi_write16(rspi, DUMMY_DATA, RSPI_SPDR);
> Doesn't the comment make it obvious already ?
To be honest that had been my thought as well but if it makes the people
working on the driver happy...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-30 11:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 9:49 [PATCH 0/5] spi: rspi: cleanups Geert Uytterhoeven
2013-12-24 9:49 ` [PATCH 3/5] spi: rspi: Make more pointers const Geert Uytterhoeven
[not found] ` <1387878574-21445-1-git-send-email-geert+renesas-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2013-12-24 9:49 ` [PATCH 1/5] spi: rspi: Use dev_get_platdata() instead of raw dev.platform_data access Geert Uytterhoeven
2013-12-24 9:49 ` [PATCH 2/5] spi: rspi: Remove casts Geert Uytterhoeven
2013-12-27 14:33 ` Laurent Pinchart
2013-12-27 18:38 ` Geert Uytterhoeven
[not found] ` <CAMuHMdXyeRdgFJF0MzJkJ5jf1pSWfO98mdn-JSF0ze2iuTbLug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-28 11:44 ` Laurent Pinchart
2013-12-24 9:49 ` [PATCH 4/5] spi: rspi: Use DUMMY_DATA macro instead of hardcoded value Geert Uytterhoeven
[not found] ` <1387878574-21445-5-git-send-email-geert+renesas-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2013-12-27 14:36 ` Laurent Pinchart
2013-12-30 11:54 ` Mark Brown [this message]
2013-12-24 9:49 ` [PATCH 5/5] spi: rspi: Use u8 for 8-bit register values Geert Uytterhoeven
2013-12-24 13:20 ` [PATCH 0/5] spi: rspi: cleanups Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131230115420.GI31886@sirena.org.uk \
--to=broonie@kernel.org \
--cc=geert+renesas@linux-m68k.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).