From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: r8a7791: Wait for status on all MSTP clocks
Date: Thu, 09 Jan 2014 05:08:35 +0000 [thread overview]
Message-ID: <20140109050832.GF2132@verge.net.au> (raw)
In-Reply-To: <1389167686-13458-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Wed, Jan 08, 2014 at 05:14:07PM +0900, Magnus Damm wrote:
> On Wed, Jan 8, 2014 at 5:13 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
> > On Wed, Jan 8, 2014 at 4:54 PM, Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com> wrote:
> >> From: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
> >>
> >> When enabling a module clock by clearing its bit in the MSTP control
> >> register, the CPG requires waiting for the status register to signal
> >> that the clock has started. Failure to do so will result in returning
> >> from the clk_enable() call with the clock potentially still disabled,
> >> leading to various race conditions and difficult to debug errors.
> >>
> >> Enable status wait for all MSTP clocks on the r8a7791.
> >>
> >> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> >
> > Looking good, thanks for your help!
>
> And yes, I'm too trigger happy as usual so I forgot:
>
> Acked-by: Magnus Damm <damm@opensource.se>
Thanks, I will queue this up.
prev parent reply other threads:[~2014-01-09 5:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 7:54 [PATCH] ARM: shmobile: r8a7791: Wait for status on all MSTP clocks Laurent Pinchart
2014-01-08 8:13 ` Magnus Damm
2014-01-08 8:14 ` Magnus Damm
2014-01-09 5:08 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109050832.GF2132@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).