From: Magnus Damm <magnus.damm@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/03] ARM: shmobile: Remove Lager USBHS UDC ifdefs
Date: Wed, 29 Jan 2014 23:10:09 +0000 [thread overview]
Message-ID: <20140129231009.22655.45084.sendpatchset@w520> (raw)
In-Reply-To: <20140129230959.22655.55645.sendpatchset@w520>
From: Magnus Damm <damm@opensource.se>
Remove ifdefs to make the Lager USBHS device always present.
This makes it more like other devices, no need to be special.
Also, these ifdefs by themselves do not hurt much, but combined
with USB Host device ifdefs that were proposed earlier we could
basically end up with a kernel that drives VBUS incorrectly
depending on the kernel configuration - lets not do that.
Signed-off-by: Magnus Damm <damm@opensource.se>
---
arch/arm/mach-shmobile/board-lager.c | 4 ----
1 file changed, 4 deletions(-)
--- 0003/arch/arm/mach-shmobile/board-lager.c
+++ work/arch/arm/mach-shmobile/board-lager.c 2014-01-24 10:16:15.000000000 +0900
@@ -368,7 +368,6 @@ static const struct platform_device_info
};
/* USBHS */
-#if IS_ENABLED(CONFIG_USB_RENESAS_USBHS_UDC)
static const struct resource usbhs_resources[] __initconst = {
DEFINE_RES_MEM(0xe6590000, 0x100),
DEFINE_RES_IRQ(gic_spi(107)),
@@ -478,9 +477,6 @@ static void __init lager_register_usbhs(
&usbhs_priv.info,
sizeof(usbhs_priv.info));
}
-#else /* CONFIG_USB_RENESAS_USBHS_UDC */
-static inline void lager_register_usbhs(void) { }
-#endif /* CONFIG_USB_RENESAS_USBHS_UDC */
/* USBHS PHY */
static const struct rcar_gen2_phy_platform_data usbhs_phy_pdata __initconst = {
next prev parent reply other threads:[~2014-01-29 23:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-29 23:09 [PATCH 00/03] ARM: shmobile: Lager USBHS update Magnus Damm
2014-01-29 23:10 ` Magnus Damm [this message]
2014-01-29 23:10 ` [PATCH 02/03] pinctrl: sh-pfc: r8a7790: Break out USB0 OVC/VBUS Magnus Damm
2014-01-31 1:17 ` Laurent Pinchart
2014-01-31 3:10 ` Magnus Damm
2014-02-06 6:24 ` Simon Horman
2014-02-06 11:01 ` Laurent Pinchart
2014-02-06 13:34 ` Magnus Damm
2014-02-07 0:15 ` Simon Horman
2014-02-07 0:36 ` Laurent Pinchart
2014-02-07 1:39 ` Simon Horman
2014-02-10 9:17 ` Linus Walleij
2014-02-10 12:08 ` Laurent Pinchart
2014-02-10 9:19 ` Linus Walleij
2014-01-29 23:10 ` [PATCH 03/03] ARM: shmobile: Lager USB0 cable detection workaround Magnus Damm
2014-01-31 1:14 ` Laurent Pinchart
2014-01-31 3:35 ` Magnus Damm
2014-02-06 7:00 ` Simon Horman
2014-01-31 0:44 ` [PATCH 00/03] ARM: shmobile: Lager USBHS update Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140129231009.22655.45084.sendpatchset@w520 \
--to=magnus.damm@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).