[PATCH 0/2] Add Ether DT support for R8A7790/Lager reference board

[PATCH 0/2] Add Ether DT support for R8A7790/Lager reference board

[Sergei Shtylyov]

Hello.

   Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-v3.14-rc1-20140206v2' tag. Here we add the Ether device tree
support working on the R8A7790/Lager reference board. The patchset requires the
'sh_eth' driver device tree support posted earlier in order to work.

[1/2] ARM: shmobile: r8a7790: add Ether DT support
[2/2] ARM: shmobile: lager: add Ether DT support

WBR, Sergei

[PATCH 1/2] ARM: shmobile: r8a7790: add Ether DT support

[Sergei Shtylyov]

Define the generic R8A7790 part of the Ether device node. 

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 arch/arm/boot/dts/r8a7790.dtsi |   15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

Index: renesas/arch/arm/boot/dts/r8a7790.dtsi
=================================--- renesas.orig/arch/arm/boot/dts/r8a7790.dtsi
+++ renesas/arch/arm/boot/dts/r8a7790.dtsi
@@ -1,7 +1,8 @@
 /*
  * Device Tree Source for the r8a7790 SoC
  *
- * Copyright (C) 2013 Renesas Solutions Corp.
+ * Copyright (C) 2013-2014 Renesas Solutions Corp.
+ * Copyright (C) 2014 Cogent Embedded Inc.
  *
  * This file is licensed under the terms of the GNU General Public License
  * version 2.  This program is licensed "as is" without any warranty of any
@@ -400,6 +401,18 @@
 		status = "disabled";
 	};
 
+	ether: ethernet@ee700000 {
+		compatible = "renesas,ether-r8a7790";
+		reg = <0 0xee700000 0 0x400>;
+		interrupt-parent = <&gic>;
+		interrupts = <0 162 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp8_clks R8A7790_CLK_ETHER>;
+		phy-mode = "rmii";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		status = "disabled";
+	};
+
 	sata0: sata@ee300000 {
 		compatible = "renesas,sata-r8a7790";
 		reg = <0 0xee300000 0 0x2000>;

[PATCH 2/2] ARM: shmobile: lager: add Ether DT support

[Sergei Shtylyov]

Define the Lager board dependent part of the Ether device node. 

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 arch/arm/boot/dts/r8a7790-lager.dts |   31 ++++++++++++++++++++++++++++++-
 1 file changed, 30 insertions(+), 1 deletion(-)

Index: renesas/arch/arm/boot/dts/r8a7790-lager.dts
=================================--- renesas.orig/arch/arm/boot/dts/r8a7790-lager.dts
+++ renesas/arch/arm/boot/dts/r8a7790-lager.dts
@@ -1,7 +1,8 @@
 /*
  * Device Tree Source for the Lager board
  *
- * Copyright (C) 2013 Renesas Solutions Corp.
+ * Copyright (C) 2013-2014 Renesas Solutions Corp.
+ * Copyright (C) 2014 Cogent Embedded, Inc.
  *
  * This file is licensed under the terms of the GNU General Public License
  * version 2.  This program is licensed "as is" without any warranty of any
@@ -76,12 +77,40 @@
 		renesas,function = "scif1";
 	};
 
+	ether_pins: ether {
+		renesas,groups = "eth_link", "eth_mdio", "eth_rmii";
+		renesas,function = "eth";
+	};
+
+	phy1_pins: phy1 {
+		renesas,groups = "intc_irq0";
+		renesas,function = "intc";
+	};
+
 	mmc1_pins: mmc1 {
 		renesas,groups = "mmc1_data8", "mmc1_ctrl";
 		renesas,function = "mmc1";
 	};
 };
 
+&ether {
+	pinctrl-0 = <&ether_pins>;
+	pinctrl-names = "default";
+
+	phy-handle = <&phy1>;
+	renesas,ether-link-active-low;
+	status = "ok";
+
+	phy1: ethernet-phy@1 {
+		reg = <1>;
+		interrupt-parent = <&irqc0>;
+		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+
+		pinctrl-0 = <&phy1_pins>;
+		pinctrl-names = "default";
+	};
+};
+
 &mmcif1 {
 	pinctrl-0 = <&mmc1_pins>;
 	pinctrl-names = "default";

[PATCH 0/2] Add Ether DT support for R8A7791/Koelsch reference board

[Sergei Shtylyov]

Hello.

   Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-v3.14-rc1-20140206v2' tag. Here we add the Ether device tree
support working on the R8A7791/Koelsch reference board. The patchset requires
the 'sh_eth' driver device tree support posted earlier in order to work.

[1/2] ARM: shmobile: r8a7791: add Ether DT support
[2/2] ARM: shmobile: koelsch: add Ether DT support

WBR, Sergei

[PATCH 2/2] ARM: shmobile: koelsch: add Ether DT support

[Sergei Shtylyov]

Define the Koelsch board dependent part of the Ether device node. 

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 arch/arm/boot/dts/r8a7791-koelsch.dts |   31 ++++++++++++++++++++++++++++++-
 1 file changed, 30 insertions(+), 1 deletion(-)

Index: renesas/arch/arm/boot/dts/r8a7791-koelsch.dts
=================================--- renesas.orig/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ renesas/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -2,7 +2,8 @@
  * Device Tree Source for the Koelsch board
  *
  * Copyright (C) 2013 Renesas Electronics Corporation
- * Copyright (C) 2013 Renesas Solutions Corp.
+ * Copyright (C) 2013-2014 Renesas Solutions Corp.
+ * Copyright (C) 2014 Cogent Embedded, Inc.
  *
  * This file is licensed under the terms of the GNU General Public License
  * version 2.  This program is licensed "as is" without any warranty of any
@@ -122,12 +123,40 @@
 		renesas,function = "scif1";
 	};
 
+	ether_pins: ether {
+		renesas,groups = "eth_link", "eth_mdio", "eth_rmii";
+		renesas,function = "eth";
+	};
+
+	phy1_pins: phy1 {
+		renesas,groups = "intc_irq0";
+		renesas,function = "intc";
+	};
+
 	qspi_pins: spi {
 		renesas,groups = "qspi_ctrl", "qspi_data4";
 		renesas,function = "qspi";
 	};
 };
 
+&ether {
+	pinctrl-0 = <&ether_pins>;
+	pinctrl-names = "default";
+
+	phy-handle = <&phy1>;
+	renesas,ether-link-active-low;
+	status = "ok";
+
+	phy1: ethernet-phy@1 {
+		reg = <1>;
+		interrupt-parent = <&irqc0>;
+		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+
+		pinctrl-0 = <&phy1_pins>;
+		pinctrl-names = "default";
+	};
+};
+
 &sata0 {
 	status = "okay";
 };

Re: [PATCH 2/2] ARM: shmobile: koelsch: add Ether DT support

[Laurent Pinchart]

Hi Sergei,

Thanks a lot for the patch.

On Friday 07 February 2014 01:14:26 Sergei Shtylyov wrote:
> Define the Koelsch board dependent part of the Ether device node.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> ---
>  arch/arm/boot/dts/r8a7791-koelsch.dts |   31 +++++++++++++++++++++++++++++-
>  1 file changed, 30 insertions(+), 1 deletion(-)
> 
> Index: renesas/arch/arm/boot/dts/r8a7791-koelsch.dts
> =================================> --- renesas.orig/arch/arm/boot/dts/r8a7791-koelsch.dts
> +++ renesas/arch/arm/boot/dts/r8a7791-koelsch.dts
> @@ -2,7 +2,8 @@
>   * Device Tree Source for the Koelsch board
>   *
>   * Copyright (C) 2013 Renesas Electronics Corporation
> - * Copyright (C) 2013 Renesas Solutions Corp.
> + * Copyright (C) 2013-2014 Renesas Solutions Corp.
> + * Copyright (C) 2014 Cogent Embedded, Inc.
>   *
>   * This file is licensed under the terms of the GNU General Public License
>   * version 2.  This program is licensed "as is" without any warranty of any
> @@ -122,12 +123,40 @@
>  		renesas,function = "scif1";
>  	};
> 
> +	ether_pins: ether {
> +		renesas,groups = "eth_link", "eth_mdio", "eth_rmii";
> +		renesas,function = "eth";
> +	};
> +
> +	phy1_pins: phy1 {
> +		renesas,groups = "intc_irq0";
> +		renesas,function = "intc";
> +	};
> +
>  	qspi_pins: spi {
>  		renesas,groups = "qspi_ctrl", "qspi_data4";
>  		renesas,function = "qspi";
>  	};
>  };
> 
> +&ether {
> +	pinctrl-0 = <&ether_pins>;
> +	pinctrl-names = "default";
> +
> +	phy-handle = <&phy1>;
> +	renesas,ether-link-active-low;
> +	status = "ok";
> +
> +	phy1: ethernet-phy@1 {
> +		reg = <1>;
> +		interrupt-parent = <&irqc0>;
> +		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> +
> +		pinctrl-0 = <&phy1_pins>;
> +		pinctrl-names = "default";

I think the PHY pins should be moved to the ethernet device. The reason for 
this is that the PHY device is discovered dynamically at runtime, and has thus 
no DT node associated with its struct device to control pinctrl automatically. 
This should probably be fixed, but in the meantime moving the PHY pins to the 
ethernet device should fix the problem.

As a last step we're missing a DT equivalent to our board code 
koelsch_ksz8041_fixup() workaround. Adding a property to specify LEDs usage to 
the PHY DT node shouldn't be difficult, but associating that node to the PHY 
device and handling the property in the PHY driver will require a bit of work. 
Is this on your to-do list ?

> +	};
> +};
> +
>  &sata0 {
>  	status = "okay";
>  };

-- 
Regards,

Laurent Pinchart

Re: [PATCH 0/2] Add Ether DT support for R8A7790/Lager reference board

[Simon Horman]

On Fri, Feb 07, 2014 at 12:54:38AM +0300, Sergei Shtylyov wrote:
> Hello.
> 
>    Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
> 'renesas-devel-v3.14-rc1-20140206v2' tag. Here we add the Ether device tree
> support working on the R8A7790/Lager reference board. The patchset requires the
> 'sh_eth' driver device tree support posted earlier in order to work.
> 
> [1/2] ARM: shmobile: r8a7790: add Ether DT support
> [2/2] ARM: shmobile: lager: add Ether DT support

Thanks. Please repost this series once the bindings have been accepted.

Re: [PATCH 0/2] Add Ether DT support for R8A7791/Koelsch reference board

[Simon Horman]

On Fri, Feb 07, 2014 at 01:10:17AM +0300, Sergei Shtylyov wrote:
> Hello.
> 
>    Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
> 'renesas-devel-v3.14-rc1-20140206v2' tag. Here we add the Ether device tree
> support working on the R8A7791/Koelsch reference board. The patchset requires
> the 'sh_eth' driver device tree support posted earlier in order to work.
> 
> [1/2] ARM: shmobile: r8a7791: add Ether DT support
> [2/2] ARM: shmobile: koelsch: add Ether DT support

Thanks. Please repost this series once the bindings have been accepted.

Re: [PATCH 0/2] Add Ether DT support for R8A7790/Lager reference board

[Sergei Shtylyov]

Hello.

On 02/13/2014 09:02 AM, Simon Horman wrote:

>>     Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
>> 'renesas-devel-v3.14-rc1-20140206v2' tag. Here we add the Ether device tree
>> support working on the R8A7790/Lager reference board. The patchset requires the
>> 'sh_eth' driver device tree support posted earlier in order to work.

>> [1/2] ARM: shmobile: r8a7790: add Ether DT support
>> [2/2] ARM: shmobile: lager: add Ether DT support

> Thanks. Please repost this series once the bindings have been accepted.

    DaveM has just merged the bindings into net-next. Time to repost these 2 
series?

WBR, Sergei

Re: [PATCH 0/2] Add Ether DT support for R8A7790/Lager reference board

[Simon Horman]

On Wed, Feb 19, 2014 at 02:40:12AM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 02/13/2014 09:02 AM, Simon Horman wrote:
> 
> >>    Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
> >>'renesas-devel-v3.14-rc1-20140206v2' tag. Here we add the Ether device tree
> >>support working on the R8A7790/Lager reference board. The patchset requires the
> >>'sh_eth' driver device tree support posted earlier in order to work.
> 
> >>[1/2] ARM: shmobile: r8a7790: add Ether DT support
> >>[2/2] ARM: shmobile: lager: add Ether DT support
> 
> >Thanks. Please repost this series once the bindings have been accepted.
> 
>    DaveM has just merged the bindings into net-next. Time to repost
> these 2 series?

Yes, I think so.

Congratulations on getting the bindings merged.