From mboxrd@z Thu Jan 1 00:00:00 1970 From: Magnus Damm Date: Tue, 18 Feb 2014 02:11:11 +0000 Subject: [PATCH 03/08] PCI: rcar: fix bridge logic configuration accesses Message-Id: <20140218021111.14164.93740.sendpatchset@w520> List-Id: References: <20140218021041.14164.56411.sendpatchset@w520> In-Reply-To: <20140218021041.14164.56411.sendpatchset@w520> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-pci@vger.kernel.org Cc: horms@verge.net.au, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, valentine.barshak@cogentembedded.com, ben.dooks@codethink.co.uk, geert@linux-m68k.org, bhelgaas@google.com, Magnus Damm From: Ben Dooks The bridge logic at slot 0 only supports reads up to 0x40 and the rest of the PCI configuration space for this slot is marked as reserved in the manual. Trying a read from offset 0x100 is producing an error from the bridge. With error interrupts enabled, the following is printed: pci-rcar-gen2 ee0d0000.pci: error irq: status 00000014 Signed-off-by: Ben Dooks Signed-off-by: Magnus Damm --- drivers/pci/host/pci-rcar-gen2.c | 4 ++++ 1 file changed, 4 insertions(+) --- 0005/drivers/pci/host/pci-rcar-gen2.c +++ work/drivers/pci/host/pci-rcar-gen2.c 2014-02-13 09:45:45.000000000 +0900 @@ -119,6 +119,10 @@ static void __iomem *rcar_pci_cfg_base(s if (slot > 2) return NULL; + /* bridge logic only has registers to 0x40 */ + if (slot = 0x0 && where >= 0x40) + return NULL; + val = slot ? RCAR_AHBPCI_WIN1_DEVICE | RCAR_AHBPCI_WIN_CTR_CFG : RCAR_AHBPCI_WIN1_HOST | RCAR_AHBPCI_WIN_CTR_CFG;