From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 04/20] ARM: shmobile: r8a7779: Add clocks
Date: Wed, 26 Feb 2014 08:55:49 +0000 [thread overview]
Message-ID: <20140226085548.GA7720@verge.net.au> (raw)
In-Reply-To: <CAMuHMdWUWeqhH_OeOOFDhTFAGfa3EtTSfMWEkYUrQNV4OT1DLA@mail.gmail.com>
On Wed, Feb 26, 2014 at 09:13:47AM +0100, Geert Uytterhoeven wrote:
> On Wed, Feb 26, 2014 at 8:33 AM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > + /* Gate clocks */
> > + mstp0_clks: mstp0_clks {
> > + compatible = "renesas,r8a7779-mstp-clocks", "renesas,cpg-mstp-clocks";
> > + reg = <0 0xffc80030 0 4>;
> > + clocks = <&cpg_clocks R8A7779_CLK_P>, <&cpg_clocks R8A7779_CLK_P>, <&cpg_clocks R8A7779_CLK_P>,
> > + <&cpg_clocks R8A7779_CLK_P>, <&cpg_clocks R8A7779_CLK_P>, <&cpg_clocks R8A7779_CLK_P>,
> > + <&cpg_clocks R8A7779_CLK_P>, <&cpg_clocks R8A7779_CLK_P>, <&cpg_clocks R8A7779_CLK_P>,
> > + <&cpg_clocks R8A7779_CLK_P>, <&cpg_clocks R8A7779_CLK_P>, <&cpg_clocks R8A7779_CLK_P>,
> > + <&cpg_clocks R8A7779_CLK_P>, <&cpg_clocks R8A7779_CLK_P>, <&cpg_clocks R8A7779_CLK_P>,
> > + <&cpg_clocks R8A7779_CLK_P>;
>
> Is there any rationale behind the decision to (not) split long lines?
> The above are really long.
>
> > + #clock-cells = <1>;
> > + renesas,clock-indices = <
> > + R8A7779_CLK_HSPI R8A7779_CLK_TMU0 R8A7779_CLK_TMU0
> > + R8A7779_CLK_TMU0 R8A7779_CLK_SCIF5 R8A7779_CLK_SCIF4
> > + R8A7779_CLK_SCIF3 R8A7779_CLK_SCIF2 R8A7779_CLK_SCIF1
> > + R8A7779_CLK_SCIF0 R8A7779_CLK_I2C3 R8A7779_CLK_I2C2
> > + R8A7779_CLK_I2C1 R8A7779_CLK_I2C0
>
> A bit longer than 80 characters (fine for me, though).
>
> > + >;
> > + clock-output-names > > + "hspi", "tmu00", "tmu01",
> > + "tmu02", "scif5", "scif4",
> > + "scif3", "scif2", "scif1",
> > + "scif0", "i2c3", "i2c2",
> > + "i2c1", "i2c0";
>
> Much shorter than 80 characters (to match the above?).
>
> > + };
> > + mstp1_clks: mstp1_clks {
> > + compatible = "renesas,r8a7779-mstp-clocks", "renesas,cpg-mstp-clocks";
> > + reg = <0 0xffc80034 0 4>, <0 0xffc80044 0 4>;
> > + clocks = <&cpg_clocks R8A7779_CLK_P>, <&cpg_clocks R8A7779_CLK_P>,
> > + <&cpg_clocks R8A7779_CLK_P>, <&cpg_clocks R8A7779_CLK_P>,
> > + <&cpg_clocks R8A7779_CLK_P>, <&cpg_clocks R8A7779_CLK_P>,
> > + <&cpg_clocks R8A7779_CLK_P>, <&cpg_clocks R8A7779_CLK_P>,
> > + <&cpg_clocks R8A7779_CLK_P>, <&cpg_clocks R8A7779_CLK_P>,
> > + <&cpg_clocks R8A7779_CLK_P>, <&cpg_clocks R8A7779_CLK_P>;
> > + #clock-cells = <1>;
> > + renesas,clock-indices = <
> > + R8A7779_CLK_USB01 R8A7779_CLK_USB01
>
> Fits in 80 characters.
>
> > + R8A7779_CLK_USB2 R8A7779_CLK_USB2
> > + R8A7779_CLK_DU R8A7779_CLK_VIN2
> > + R8A7779_CLK_VIN1 R8A7779_CLK_VIN0
> > + R8A7779_CLK_ETHER R8A7779_CLK_SATA
> > + R8A7779_CLK_PCIE R8A7779_CLK_VIN3
> > + >;
> > + clock-output-names > > + "ehci0", "ohci0",
> > + "ehci1", "ohci1",
> > + "du", "vin2",
> > + "vin1", "vin0",
> > + "ether", "sata",
> > + "pcie", "vin3";
>
> Reallt short, could be compacted a lot.
The rationale to have lines in clocks, renesas,clock-indices and
clock-output-names corresponding with each other. Which I found
made it easier out weed out inconsistencies.
But I'm happy to rearrange things as you suggest.
>
> > + };
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-02-26 8:55 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 7:33 [PATCH v3 00/20] ARM: shmobile: r8a7779, marzen: CCF and multiplatform Simon Horman
2014-02-26 7:33 ` [PATCH v3 01/20] clk: shmobile: r8a7779: Add clocks support Simon Horman
2014-02-26 8:05 ` Geert Uytterhoeven
2014-02-26 8:59 ` Simon Horman
2014-02-26 9:06 ` Geert Uytterhoeven
2014-02-28 1:35 ` Simon Horman
2014-02-26 12:53 ` Laurent Pinchart
2014-02-26 13:02 ` Laurent Pinchart
2014-03-12 7:55 ` Simon Horman
2014-03-12 10:12 ` Laurent Pinchart
2014-03-13 2:22 ` Simon Horman
2014-03-13 9:07 ` Laurent Pinchart
2014-03-14 0:38 ` Simon Horman
2014-03-01 13:50 ` Wolfram Sang
2014-03-01 17:33 ` Geert Uytterhoeven
2014-03-02 11:35 ` Laurent Pinchart
2014-03-02 11:51 ` Geert Uytterhoeven
2014-03-02 11:59 ` Wolfram Sang
2014-02-26 7:33 ` [PATCH v3 02/20] clk: shmobile: r8a7779: Add MSTP clock support Simon Horman
2014-02-26 12:53 ` Laurent Pinchart
2014-02-26 7:33 ` [PATCH v3 03/20] ARM: shmobile: r8a7779: Add clock index macros for DT sources Simon Horman
2014-02-26 12:56 ` Laurent Pinchart
2014-02-26 7:33 ` [PATCH v3 04/20] ARM: shmobile: r8a7779: Add clocks Simon Horman
2014-02-26 8:13 ` Geert Uytterhoeven
2014-02-26 8:55 ` Simon Horman [this message]
2014-02-26 13:15 ` Laurent Pinchart
2014-03-12 8:40 ` Simon Horman
2014-02-26 14:45 ` Laurent Pinchart
2014-03-12 8:43 ` Simon Horman
2014-03-01 14:29 ` Wolfram Sang
2014-02-26 7:33 ` [PATCH v3 05/20] ARM: shmobile: Sync Marzen DTS with Marzen reference DTS Simon Horman
2014-02-26 13:17 ` Laurent Pinchart
2014-02-26 7:33 ` [PATCH v3 06/20] ARM: shmobile: marzen: Specify external clock frequency in DT Simon Horman
2014-02-26 13:19 ` Laurent Pinchart
2014-02-26 7:33 ` [PATCH v3 07/20] ARM: shmobile: marzen: Reference clocks Simon Horman
2014-02-26 13:20 ` Laurent Pinchart
2014-02-26 14:23 ` Sergei Shtylyov
2014-03-13 0:09 ` Simon Horman
2014-02-26 7:33 ` [PATCH v3 08/20] ARM: shmobile: r8a7779: " Simon Horman
2014-02-26 13:21 ` Laurent Pinchart
2014-02-26 7:33 ` [PATCH v3 09/20] ARM: shmobile: r8a7779: Add helper to read mode pins Simon Horman
2014-02-26 7:33 ` [PATCH v3 10/20] ARM: shmobile: r8a7779: Move r8a7779_earlytimer_init to clock-r8a7779.c Simon Horman
2014-02-26 7:33 ` [PATCH v3 11/20] ARM: shmobile: marzen-reference: Move clock and OF device initialisation into board Simon Horman
2014-02-26 7:33 ` [PATCH v3 12/20] ARM: shmobile: r8a7779: Do not include sh_clk.h in r8a7779.h Simon Horman
2014-02-26 7:33 ` [PATCH v3 13/20] ARM: shmobile: r8a7779: Initial multiplatform support Simon Horman
2014-02-26 7:33 ` [PATCH v3 14/20] ARM: shmobile: marzen-reference: Initialize CPG device Simon Horman
2014-02-26 13:22 ` Laurent Pinchart
2014-02-26 7:33 ` [PATCH v3 15/20] ARM: shmobile: marzen-reference: Instantiate clkdevs for SCIF and TMU Simon Horman
2014-02-26 8:29 ` Geert Uytterhoeven
2014-02-26 8:56 ` Simon Horman
2014-02-26 13:24 ` Laurent Pinchart
2014-03-13 0:03 ` Simon Horman
2014-02-26 7:33 ` [PATCH v3 16/20] ARM: shmobile: marzen: Add to shmobile defconfig Simon Horman
2014-02-26 7:33 ` [PATCH v3 17/20] ARM: shmobile: Remove non-multiplatform Marzen reference support Simon Horman
2014-02-26 7:33 ` [PATCH v3 18/20] ARM: shmobile: Let Marzen multiplatform boot with Marzen DTB Simon Horman
2014-02-26 7:33 ` [PATCH v3 19/20] ARM: shmobile: Remove Marzen reference DTS Simon Horman
2014-02-26 7:33 ` [PATCH v3 20/20] ARM: shmobile: marzen-reference: Remove legacy clock support Simon Horman
2014-02-26 8:33 ` Geert Uytterhoeven
2014-02-26 8:57 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140226085548.GA7720@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).