* [PATCH] ARM: shmobile: APMU: Fix warnings due to improper printk formats
@ 2014-03-04 18:11 Laurent Pinchart
2014-03-05 10:06 ` Magnus Damm
2014-03-06 4:14 ` Simon Horman
0 siblings, 2 replies; 4+ messages in thread
From: Laurent Pinchart @ 2014-03-04 18:11 UTC (permalink / raw)
To: linux-sh
Use the %pr printk specifier to print resource variables. This fixes
warnings on platforms where resource_size_t has a different size than
int.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
arch/arm/mach-shmobile/platsmp-apmu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/mach-shmobile/platsmp-apmu.c b/arch/arm/mach-shmobile/platsmp-apmu.c
index 1da5a72..8cb641c 100644
--- a/arch/arm/mach-shmobile/platsmp-apmu.c
+++ b/arch/arm/mach-shmobile/platsmp-apmu.c
@@ -75,8 +75,7 @@ static void apmu_init_cpu(struct resource *res, int cpu, int bit)
apmu_cpus[cpu].iomem = ioremap_nocache(res->start, resource_size(res));
apmu_cpus[cpu].bit = bit;
- pr_debug("apmu ioremap %d %d 0x%08x 0x%08x\n", cpu, bit,
- res->start, resource_size(res));
+ pr_debug("apmu ioremap %d %d %pr\n", cpu, bit, res);
}
static struct {
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: shmobile: APMU: Fix warnings due to improper printk formats
2014-03-04 18:11 [PATCH] ARM: shmobile: APMU: Fix warnings due to improper printk formats Laurent Pinchart
@ 2014-03-05 10:06 ` Magnus Damm
2014-03-06 4:14 ` Simon Horman
1 sibling, 0 replies; 4+ messages in thread
From: Magnus Damm @ 2014-03-05 10:06 UTC (permalink / raw)
To: linux-sh
On Wed, Mar 5, 2014 at 3:11 AM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> Use the %pr printk specifier to print resource variables. This fixes
> warnings on platforms where resource_size_t has a different size than
> int.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> arch/arm/mach-shmobile/platsmp-apmu.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/platsmp-apmu.c b/arch/arm/mach-shmobile/platsmp-apmu.c
> index 1da5a72..8cb641c 100644
> --- a/arch/arm/mach-shmobile/platsmp-apmu.c
> +++ b/arch/arm/mach-shmobile/platsmp-apmu.c
> @@ -75,8 +75,7 @@ static void apmu_init_cpu(struct resource *res, int cpu, int bit)
> apmu_cpus[cpu].iomem = ioremap_nocache(res->start, resource_size(res));
> apmu_cpus[cpu].bit = bit;
>
> - pr_debug("apmu ioremap %d %d 0x%08x 0x%08x\n", cpu, bit,
> - res->start, resource_size(res));
> + pr_debug("apmu ioremap %d %d %pr\n", cpu, bit, res);
> }
Yes, thanks, this looks good!
/ magnus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: shmobile: APMU: Fix warnings due to improper printk formats
2014-03-04 18:11 [PATCH] ARM: shmobile: APMU: Fix warnings due to improper printk formats Laurent Pinchart
2014-03-05 10:06 ` Magnus Damm
@ 2014-03-06 4:14 ` Simon Horman
1 sibling, 0 replies; 4+ messages in thread
From: Simon Horman @ 2014-03-06 4:14 UTC (permalink / raw)
To: linux-sh
On Wed, Mar 05, 2014 at 07:06:36PM +0900, Magnus Damm wrote:
> On Wed, Mar 5, 2014 at 3:11 AM, Laurent Pinchart
> <laurent.pinchart+renesas@ideasonboard.com> wrote:
> > Use the %pr printk specifier to print resource variables. This fixes
> > warnings on platforms where resource_size_t has a different size than
> > int.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > arch/arm/mach-shmobile/platsmp-apmu.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-shmobile/platsmp-apmu.c b/arch/arm/mach-shmobile/platsmp-apmu.c
> > index 1da5a72..8cb641c 100644
> > --- a/arch/arm/mach-shmobile/platsmp-apmu.c
> > +++ b/arch/arm/mach-shmobile/platsmp-apmu.c
> > @@ -75,8 +75,7 @@ static void apmu_init_cpu(struct resource *res, int cpu, int bit)
> > apmu_cpus[cpu].iomem = ioremap_nocache(res->start, resource_size(res));
> > apmu_cpus[cpu].bit = bit;
> >
> > - pr_debug("apmu ioremap %d %d 0x%08x 0x%08x\n", cpu, bit,
> > - res->start, resource_size(res));
> > + pr_debug("apmu ioremap %d %d %pr\n", cpu, bit, res);
> > }
>
> Yes, thanks, this looks good!
Thanks, I will queue this up.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: shmobile: APMU: Fix warnings due to improper printk formats
2014-03-10 8:36 [GIT PULL] Third Round of Renesas ARM Based SoC Updates for v3.15 Simon Horman
@ 2014-03-10 8:36 ` Simon Horman
0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2014-03-10 8:36 UTC (permalink / raw)
To: linux-arm-kernel
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Use the %pr printk specifier to print resource variables. This fixes
warnings on platforms where resource_size_t has a different size than
int.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm/mach-shmobile/platsmp-apmu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/mach-shmobile/platsmp-apmu.c b/arch/arm/mach-shmobile/platsmp-apmu.c
index 1da5a72..8cb641c 100644
--- a/arch/arm/mach-shmobile/platsmp-apmu.c
+++ b/arch/arm/mach-shmobile/platsmp-apmu.c
@@ -75,8 +75,7 @@ static void apmu_init_cpu(struct resource *res, int cpu, int bit)
apmu_cpus[cpu].iomem = ioremap_nocache(res->start, resource_size(res));
apmu_cpus[cpu].bit = bit;
- pr_debug("apmu ioremap %d %d 0x%08x 0x%08x\n", cpu, bit,
- res->start, resource_size(res));
+ pr_debug("apmu ioremap %d %d %pr\n", cpu, bit, res);
}
static struct {
--
1.8.5.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-10 8:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-04 18:11 [PATCH] ARM: shmobile: APMU: Fix warnings due to improper printk formats Laurent Pinchart
2014-03-05 10:06 ` Magnus Damm
2014-03-06 4:14 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2014-03-10 8:36 [GIT PULL] Third Round of Renesas ARM Based SoC Updates for v3.15 Simon Horman
2014-03-10 8:36 ` [PATCH] ARM: shmobile: APMU: Fix warnings due to improper printk formats Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).