From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Thu, 06 Mar 2014 04:14:18 +0000 Subject: Re: [PATCH] ARM: shmobile: APMU: Fix warnings due to improper printk formats Message-Id: <20140306041414.GA29693@verge.net.au> List-Id: References: <1393956675-10701-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: <1393956675-10701-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org On Wed, Mar 05, 2014 at 07:06:36PM +0900, Magnus Damm wrote: > On Wed, Mar 5, 2014 at 3:11 AM, Laurent Pinchart > wrote: > > Use the %pr printk specifier to print resource variables. This fixes > > warnings on platforms where resource_size_t has a different size than > > int. > > > > Signed-off-by: Laurent Pinchart > > --- > > arch/arm/mach-shmobile/platsmp-apmu.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/arch/arm/mach-shmobile/platsmp-apmu.c b/arch/arm/mach-shmobile/platsmp-apmu.c > > index 1da5a72..8cb641c 100644 > > --- a/arch/arm/mach-shmobile/platsmp-apmu.c > > +++ b/arch/arm/mach-shmobile/platsmp-apmu.c > > @@ -75,8 +75,7 @@ static void apmu_init_cpu(struct resource *res, int cpu, int bit) > > apmu_cpus[cpu].iomem = ioremap_nocache(res->start, resource_size(res)); > > apmu_cpus[cpu].bit = bit; > > > > - pr_debug("apmu ioremap %d %d 0x%08x 0x%08x\n", cpu, bit, > > - res->start, resource_size(res)); > > + pr_debug("apmu ioremap %d %d %pr\n", cpu, bit, res); > > } > > Yes, thanks, this looks good! Thanks, I will queue this up.