From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux-sh@vger.kernel.org
Subject: [patch] sh: missing break statement
Date: Wed, 02 Apr 2014 16:54:49 +0000 [thread overview]
Message-ID: <20140402165449.GA10002@mwanda> (raw)
SH_BREAKPOINT_READ doesn't work because of the missing break in this
switch statement.
Fixes: 09a072947791 ('sh: hw-breakpoints: Add preliminary support for SH-4A UBC.')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/arch/sh/kernel/hw_breakpoint.c b/arch/sh/kernel/hw_breakpoint.c
index f9173766..42d30ac 100644
--- a/arch/sh/kernel/hw_breakpoint.c
+++ b/arch/sh/kernel/hw_breakpoint.c
@@ -160,6 +160,7 @@ int arch_bp_generic_fields(int sh_len, int sh_type,
switch (sh_type) {
case SH_BREAKPOINT_READ:
*gen_type = HW_BREAKPOINT_R;
+ break;
case SH_BREAKPOINT_WRITE:
*gen_type = HW_BREAKPOINT_W;
break;
reply other threads:[~2014-04-02 16:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140402165449.GA10002@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).