linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch] sh: missing break statement
@ 2014-04-02 16:54 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2014-04-02 16:54 UTC (permalink / raw)
  To: linux-sh

SH_BREAKPOINT_READ doesn't work because of the missing break in this
switch statement.

Fixes: 09a072947791 ('sh: hw-breakpoints: Add preliminary support for SH-4A UBC.')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/arch/sh/kernel/hw_breakpoint.c b/arch/sh/kernel/hw_breakpoint.c
index f9173766..42d30ac 100644
--- a/arch/sh/kernel/hw_breakpoint.c
+++ b/arch/sh/kernel/hw_breakpoint.c
@@ -160,6 +160,7 @@ int arch_bp_generic_fields(int sh_len, int sh_type,
 	switch (sh_type) {
 	case SH_BREAKPOINT_READ:
 		*gen_type = HW_BREAKPOINT_R;
+		break;
 	case SH_BREAKPOINT_WRITE:
 		*gen_type = HW_BREAKPOINT_W;
 		break;

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2014-04-02 16:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-02 16:54 [patch] sh: missing break statement Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).