From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Dooks Date: Fri, 04 Apr 2014 11:42:50 +0000 Subject: Re: [alsa-devel] [PATCH] ASoC: rsnd: SSI needs to prepare clocks before enabling Message-Id: <20140404114250.GS4400@trinity.fluff.org> List-Id: References: <1396009626-24699-1-git-send-email-ben.dooks@codethink.co.uk> <20140329100906.GE21628@sirena.org.uk> In-Reply-To: <20140329100906.GE21628@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mark Brown Cc: linux-kernel@lists.codethink.co.uk, alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com, linux-sh@vger.kernel.org, lgirdwood@gmail.com, Ben Dooks , magnus.damm@opensource.se, William Towle On Sat, Mar 29, 2014 at 10:09:06AM +0000, Mark Brown wrote: > On Fri, Mar 28, 2014 at 12:27:06PM +0000, Ben Dooks wrote: > > From: William Towle > > > > The rsnd_ssi_hw_{stop|start} functions need to call clk_prepare_enable() > > and clk_disable_unprepare(), otherwise the following warning occurs on > > attempt to play sound: > > This doesn't apply cleanly against current code, can you please check and > resend - I can't apply this anyway since... > > > Signed-off-by: William Towle > > [ben.dooks@codethink.co.uk: add more bug info to report] > > Tested-by: Ben Dooks > > --- > > ...you forgot to sign off. I'm also not seeing the debug info you > mention in the changelog, indeed there's no error checking. Ooops. I need to re-do this anyway as we need to prepare the clock separately from the enable, as the enable code is occasionally being called from an interrupt context. I anm not sure what you mean by debug info... there is the log from the WARN_ON() which is trigger from the clock driver. -- Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear.