[PATCH] ARM: shmobile: armadillo-reference: Add PWM backlight node to DT

[PATCH] ARM: shmobile: armadillo-reference: Add PWM backlight node to DT

[Laurent Pinchart]

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 .../boot/dts/r8a7740-armadillo800eva-reference.dts    | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
index c638e4a..801442b 100644
--- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
+++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
@@ -11,6 +11,7 @@
 /dts-v1/;
 /include/ "r8a7740.dtsi"
 #include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/pwm/pwm.h>
 
 / {
 	model = "armadillo 800 eva reference";
@@ -49,6 +50,15 @@
 			gpios = <&pfc 177 GPIO_ACTIVE_HIGH>;
 		};
 	};
+
+	backlight {
+		compatible = "pwm-backlight";
+		pwms = <&tpu 2 33333 PWM_POLARITY_INVERTED>;
+		brightness-levels = <0 1 2 4 8 16 32 64 128 255>;
+		default-brightness-level = <9>;
+		pinctrl-0 = <&backlight_pins>;
+		pinctrl-names = "default";
+	};
 };
 
 &i2c0 {
@@ -76,4 +86,13 @@
 		renesas,groups = "intc_irq10";
 		renesas,function = "intc";
 	};
+
+	backlight_pins: backlight {
+		renesas,groups = "tpu0_to2_1";
+		renesas,function = "tpu0";
+	};
+};
+
+&tpu {
+	status = "okay";
 };
-- 
Regards,

Laurent Pinchart

Re: [PATCH] ARM: shmobile: armadillo-reference: Add PWM backlight node to DT

[Simon Horman]

On Wed, Sep 11, 2013 at 01:51:13PM +0200, Laurent Pinchart wrote:
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  .../boot/dts/r8a7740-armadillo800eva-reference.dts    | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)

Thanks, I have queued this up for v3.13.
It should appear in the devel branch of the renesas tree the
next time I push. That will most likely be in the next few hours.

[PATCH] ARM: shmobile: armadillo-reference dts: enable RTC

[Ulrich Hecht]

This enables the Seiko real-time clock that is attached to a couple of
GPIO pins.

Signed-off-by: Ulrich Hecht <ulrich.hecht@gmail.com>
---
 .../arm/boot/dts/r8a7740-armadillo800eva-reference.dts | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
index b79ea51..ac352ef 100644
--- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
+++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
@@ -118,6 +118,16 @@
 		};
 	};
 
+	i2c2: i2c@2 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "i2c-gpio";
+		gpios = <&pfc 208 GPIO_ACTIVE_HIGH /* sda */
+			 &pfc 91 GPIO_ACTIVE_HIGH /* scl */
+			>;
+		i2c-gpio,delay-us = <5>;
+	};
+
 	backlight {
 		compatible = "pwm-backlight";
 		pwms = <&tpu 2 33333 PWM_POLARITY_INVERTED>;
@@ -178,6 +188,14 @@
 	};
 };
 
+&i2c2 {
+	status = "okay";
+	rtc@30 {
+		compatible = "seiko,s35390a";
+		reg = <0x30>;
+	};
+};
+
 &pfc {
 	pinctrl-0 = <&scifa1_pins>;
 	pinctrl-names = "default";
-- 
1.8.4.5

Re: [PATCH] ARM: shmobile: armadillo-reference dts: enable RTC

[Simon Horman]

On Mon, Mar 31, 2014 at 05:38:20PM +0200, Ulrich Hecht wrote:
> This enables the Seiko real-time clock that is attached to a couple of
> GPIO pins.

Hi Ulrich,

I am a little confused about i2c2 appearing below as
the documentation that I have only seems to refer to
the presence of i2c0 and i2c1.

> 
> Signed-off-by: Ulrich Hecht <ulrich.hecht@gmail.com>
> ---
>  .../arm/boot/dts/r8a7740-armadillo800eva-reference.dts | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> index b79ea51..ac352ef 100644
> --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> @@ -118,6 +118,16 @@
>  		};
>  	};
>  
> +	i2c2: i2c@2 {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		compatible = "i2c-gpio";
> +		gpios = <&pfc 208 GPIO_ACTIVE_HIGH /* sda */
> +			 &pfc 91 GPIO_ACTIVE_HIGH /* scl */
> +			>;
> +		i2c-gpio,delay-us = <5>;
> +	};
> +
>  	backlight {
>  		compatible = "pwm-backlight";
>  		pwms = <&tpu 2 33333 PWM_POLARITY_INVERTED>;
> @@ -178,6 +188,14 @@
>  	};
>  };
>  
> +&i2c2 {
> +	status = "okay";
> +	rtc@30 {
> +		compatible = "seiko,s35390a";
> +		reg = <0x30>;
> +	};
> +};
> +
>  &pfc {
>  	pinctrl-0 = <&scifa1_pins>;
>  	pinctrl-names = "default";
> -- 
> 1.8.4.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH] ARM: shmobile: armadillo-reference dts: enable RTC

[Ulrich Hecht]

Hi!

On Thu, Apr 3, 2014 at 2:11 AM, Simon Horman <horms@verge.net.au> wrote:
> I am a little confused about i2c2 appearing below as
> the documentation that I have only seems to refer to
> the presence of i2c0 and i2c1.

This thing doesn't use any of the SoC I2C controllers, it's just
hooked up to two GPIO pins. The board docs don't give much detail, but
I found the relevant info in the Android vendor kernel, which is where
this "bus" is called i2c2. The name is arbitrary, though.

CU
Uli

Re: [PATCH] ARM: shmobile: armadillo-reference dts: enable RTC

[Geert Uytterhoeven]

On Thu, Apr 3, 2014 at 10:30 AM, Ulrich Hecht <ulrich.hecht@gmail.com> wrote:
> On Thu, Apr 3, 2014 at 2:11 AM, Simon Horman <horms@verge.net.au> wrote:
>> I am a little confused about i2c2 appearing below as
>> the documentation that I have only seems to refer to
>> the presence of i2c0 and i2c1.
>
> This thing doesn't use any of the SoC I2C controllers, it's just
> hooked up to two GPIO pins. The board docs don't give much detail, but
> I found the relevant info in the Android vendor kernel, which is where
> this "bus" is called i2c2. The name is arbitrary, though.

Table 3.1 does mention "I2C2 (GPIO) For RTC only", and the docs also
mention it's a s35390a.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] ARM: shmobile: armadillo-reference dts: enable RTC

[Geert Uytterhoeven]

(cc devicetree)

On Mon, Mar 31, 2014 at 5:38 PM, Ulrich Hecht <ulrich.hecht@gmail.com> wrote:
> This enables the Seiko real-time clock that is attached to a couple of
> GPIO pins.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht@gmail.com>
> ---
>  .../arm/boot/dts/r8a7740-armadillo800eva-reference.dts | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> index b79ea51..ac352ef 100644
> --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> @@ -118,6 +118,16 @@
>                 };
>         };
>
> +       i2c2: i2c@2 {
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               compatible = "i2c-gpio";
> +               gpios = <&pfc 208 GPIO_ACTIVE_HIGH /* sda */
> +                        &pfc 91 GPIO_ACTIVE_HIGH /* scl */
> +                       >;
> +               i2c-gpio,delay-us = <5>;
> +       };
> +
>         backlight {
>                 compatible = "pwm-backlight";
>                 pwms = <&tpu 2 33333 PWM_POLARITY_INVERTED>;
> @@ -178,6 +188,14 @@
>         };
>  };
>
> +&i2c2 {
> +       status = "okay";
> +       rtc@30 {
> +               compatible = "seiko,s35390a";

I think this should be "sii,s35390a", for Seiko Instruments Inc.

> +               reg = <0x30>;
> +       };
> +};
> +
>  &pfc {
>         pinctrl-0 = <&scifa1_pins>;
>         pinctrl-names = "default";
> --
> 1.8.4.5

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] ARM: shmobile: armadillo-reference dts: enable RTC

[Geert Uytterhoeven]

On Thu, Apr 3, 2014 at 11:40 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Thu, Apr 3, 2014 at 10:30 AM, Ulrich Hecht <ulrich.hecht@gmail.com> wrote:
>> On Thu, Apr 3, 2014 at 2:11 AM, Simon Horman <horms@verge.net.au> wrote:
>>> I am a little confused about i2c2 appearing below as
>>> the documentation that I have only seems to refer to
>>> the presence of i2c0 and i2c1.
>>
>> This thing doesn't use any of the SoC I2C controllers, it's just
>> hooked up to two GPIO pins. The board docs don't give much detail, but
>> I found the relevant info in the Android vendor kernel, which is where
>> this "bus" is called i2c2. The name is arbitrary, though.
>
> Table 3.1 does mention "I2C2 (GPIO) For RTC only", and the docs also
> mention it's a s35390a.

And board-armadillo800eva.c also contains support for it.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] ARM: shmobile: armadillo-reference dts: enable RTC

[Simon Horman]

On Fri, Apr 04, 2014 at 12:06:12PM +0200, Geert Uytterhoeven wrote:
> On Thu, Apr 3, 2014 at 11:40 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > On Thu, Apr 3, 2014 at 10:30 AM, Ulrich Hecht <ulrich.hecht@gmail.com> wrote:
> >> On Thu, Apr 3, 2014 at 2:11 AM, Simon Horman <horms@verge.net.au> wrote:
> >>> I am a little confused about i2c2 appearing below as
> >>> the documentation that I have only seems to refer to
> >>> the presence of i2c0 and i2c1.
> >>
> >> This thing doesn't use any of the SoC I2C controllers, it's just
> >> hooked up to two GPIO pins. The board docs don't give much detail, but
> >> I found the relevant info in the Android vendor kernel, which is where
> >> this "bus" is called i2c2. The name is arbitrary, though.
> >
> > Table 3.1 does mention "I2C2 (GPIO) For RTC only", and the docs also
> > mention it's a s35390a.

I think you may have a different version of the documentation to me.
But in any case I trust the combined judgement of you and Ulrich.

> And board-armadillo800eva.c also contains support for it.

That I see :)

I will queue up this patch.

[PATCH] ARM: shmobile: armadillo-reference dts: Seiko Instruments, Inc is "sii"

[Geert Uytterhoeven]

Use "sii,s35390a" instead of "seiko,s35390a", cfr.
Documentation/devicetree/bindings/i2c/trivial-devices.txt and
Documentation/devicetree/bindings/vendor-prefixes.txt.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 .../boot/dts/r8a7740-armadillo800eva-reference.dts |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
index 0cb235a450b9..10344e6edd20 100644
--- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
+++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
@@ -180,7 +180,7 @@
 &i2c2 {
 	status = "okay";
 	rtc@30 {
-		compatible = "seiko,s35390a";
+		compatible = "sii,s35390a";
 		reg = <0x30>;
 	};
 };
-- 
1.7.9.5

Re: [PATCH] ARM: shmobile: armadillo-reference dts: Seiko Instruments, Inc is "sii"

[Ulrich Hecht]

On Tue, Apr 15, 2014 at 2:51 PM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> Use "sii,s35390a" instead of "seiko,s35390a", cfr.
> Documentation/devicetree/bindings/i2c/trivial-devices.txt and
> Documentation/devicetree/bindings/vendor-prefixes.txt.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>

> ---
>  .../boot/dts/r8a7740-armadillo800eva-reference.dts |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> index 0cb235a450b9..10344e6edd20 100644
> --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> @@ -180,7 +180,7 @@
>  &i2c2 {
>         status = "okay";
>         rtc@30 {
> -               compatible = "seiko,s35390a";
> +               compatible = "sii,s35390a";
>                 reg = <0x30>;
>         };
>  };
> --
> 1.7.9.5
>

CU
Uli

Re: [PATCH] ARM: shmobile: armadillo-reference dts: Seiko Instruments, Inc is "sii"

[Simon Horman]

On Tue, Apr 15, 2014 at 04:26:55PM +0200, Ulrich Hecht wrote:
> On Tue, Apr 15, 2014 at 2:51 PM, Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
> > Use "sii,s35390a" instead of "seiko,s35390a", cfr.
> > Documentation/devicetree/bindings/i2c/trivial-devices.txt and
> > Documentation/devicetree/bindings/vendor-prefixes.txt.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Acked-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>

Thanks, I will queue this up.