From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] [RFC] ARM: shmobile: Enable shmobile Runtime PM from MSTP clock driver
Date: Mon, 28 Apr 2014 06:55:02 +0000 [thread overview]
Message-ID: <20140428065500.GA21494@verge.net.au> (raw)
In-Reply-To: <1398445124-16828-1-git-send-email-geert+renesas@glider.be>
On Mon, Apr 28, 2014 at 07:45:38AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Mon, Apr 28, 2014 at 2:10 AM, Simon Horman <horms@verge.net.au> wrote:
> >> --- a/drivers/sh/pm_runtime.c
> >> +++ b/drivers/sh/pm_runtime.c
> >> @@ -75,20 +75,24 @@ static struct pm_clk_notifier_block platform_bus_notifier = {
> >> .con_ids = { NULL, },
> >> };
> >>
> >> -static bool default_pm_on;
> >> +#if defined(CONFIG_SUPERH) || defined(CONFIG_ARCH_SHMOBILE_LEGACY)
> >> +bool default_pm_on = true;
> >> +#else
> >> +bool default_pm_on;
> >> +#endif
> >
> > I wonder if there is some way we can get the compiler
> > to optimise out code in the case of default_pm_on = false,
> > perhaps by using IS_ENABLED() in conjunction with a Kconfig variable.
>
> What's the use case of that?
>
> This code is compiled only if SUPERH || ARCH_SHMOBILE_LEGACY ||
> ARCH_SHMOBILE_MULTIPLATORM.
> If should always be used when running on shmobile.
Sorry, I missed that point.
Please ignore my previous comment.
prev parent reply other threads:[~2014-04-28 6:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 16:58 [PATCH] [RFC] ARM: shmobile: Enable shmobile Runtime PM from MSTP clock driver Geert Uytterhoeven
2014-04-28 0:10 ` Simon Horman
2014-04-28 5:45 ` Geert Uytterhoeven
2014-04-28 6:55 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140428065500.GA21494@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox