linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	linux-sh@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: rsnd: Fix warnings due to improper printk formats
Date: Tue, 13 May 2014 21:39:40 +0000	[thread overview]
Message-ID: <20140513213935.GA6784@verge.net.au> (raw)
In-Reply-To: <871tvysge5.wl%kuninori.morimoto.gx@renesas.com>

On Mon, May 12, 2014 at 04:53:44PM -0700, Kuninori Morimoto wrote:
> 
> Hi
> 
> Thank you for your help
> 
> > Use the %pap printk specifier to print resource_size_t variables. This
> > fixes warnings on platforms where resource_size_t has a different size
> > than int.
> > 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> 
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Morimoto-san, should Mark Brown need to be CCed on a re-post
in order for him to see this?

> >  sound/soc/sh/rcar/gen.c | 14 +++++++-------
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> > 
> > Would it be possible to get this patch in v3.16 ?
> > 
> > diff --git a/sound/soc/sh/rcar/gen.c b/sound/soc/sh/rcar/gen.c
> > index 50a1ef3..1d5c025 100644
> > --- a/sound/soc/sh/rcar/gen.c
> > +++ b/sound/soc/sh/rcar/gen.c
> > @@ -252,13 +252,13 @@ static int rsnd_gen2_probe(struct platform_device *pdev,
> >  		return ret;
> >  
> >  	dev_dbg(dev, "Gen2 device probed\n");
> > -	dev_dbg(dev, "SCU  : %08x => %p\n", scu_res->start,
> > +	dev_dbg(dev, "SCU  : %pap => %p\n", &scu_res->start,
> >  		gen->base[RSND_GEN2_SCU]);
> > -	dev_dbg(dev, "ADG  : %08x => %p\n", adg_res->start,
> > +	dev_dbg(dev, "ADG  : %pap => %p\n", &adg_res->start,
> >  		gen->base[RSND_GEN2_ADG]);
> > -	dev_dbg(dev, "SSIU : %08x => %p\n", ssiu_res->start,
> > +	dev_dbg(dev, "SSIU : %pap => %p\n", &ssiu_res->start,
> >  		gen->base[RSND_GEN2_SSIU]);
> > -	dev_dbg(dev, "SSI  : %08x => %p\n", ssi_res->start,
> > +	dev_dbg(dev, "SSI  : %pap => %p\n", &ssi_res->start,
> >  		gen->base[RSND_GEN2_SSI]);
> >  
> >  	return 0;
> > @@ -345,11 +345,11 @@ static int rsnd_gen1_probe(struct platform_device *pdev,
> >  		return ret;
> >  
> >  	dev_dbg(dev, "Gen1 device probed\n");
> > -	dev_dbg(dev, "SRU : %08x => %p\n",	sru_res->start,
> > +	dev_dbg(dev, "SRU : %pap => %p\n",	&sru_res->start,
> >  						gen->base[RSND_GEN1_SRU]);
> > -	dev_dbg(dev, "ADG : %08x => %p\n",	adg_res->start,
> > +	dev_dbg(dev, "ADG : %pap => %p\n",	&adg_res->start,
> >  						gen->base[RSND_GEN1_ADG]);
> > -	dev_dbg(dev, "SSI : %08x => %p\n",	ssi_res->start,
> > +	dev_dbg(dev, "SSI : %pap => %p\n",	&ssi_res->start,
> >  						gen->base[RSND_GEN1_SSI]);
> >  
> >  	return 0;
> > -- 
> > Regards,
> > 
> > Laurent Pinchart
> > 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  reply	other threads:[~2014-05-13 21:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-12 23:10 [PATCH] ASoC: rsnd: Fix warnings due to improper printk formats Laurent Pinchart
2014-05-12 23:53 ` Kuninori Morimoto
2014-05-13 21:39   ` Simon Horman [this message]
2014-05-14  2:33     ` Kuninori Morimoto
2014-05-15 10:14       ` [alsa-devel] " Mark Brown
2014-05-15 12:10         ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140513213935.GA6784@verge.net.au \
    --to=horms@verge.net.au \
    --cc=alsa-devel@alsa-project.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).