[PATCH v3 1/3] drivers: sh: pm_runtime does not need idle callback

[PATCH v3 1/3] drivers: sh: pm_runtime does not need idle callback

[Geert Uytterhoeven]

From: Ben Dooks <ben.dooks@codethink.co.uk>

In the runtime_pm idle callback the code assumes that a NULL .runtime_idle
entry is the same as a .runtime_idle entry that returns 0 as a result. This
means the entry in drivers/sh/pm_runtime can be removed in favour of just
leaving the entry NULL.

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> [r8a7779 legacy]
---
v3:
  - No changes
v2:
  - Add Reviewed-by, Tested-by
---
 drivers/sh/pm_runtime.c |    8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/sh/pm_runtime.c b/drivers/sh/pm_runtime.c
index 10c65eb51f85..00b82ec94442 100644
--- a/drivers/sh/pm_runtime.c
+++ b/drivers/sh/pm_runtime.c
@@ -21,18 +21,10 @@
 #include <linux/slab.h>
 
 #ifdef CONFIG_PM_RUNTIME
-
-static int default_platform_runtime_idle(struct device *dev)
-{
-	/* suspend synchronously to disable clocks immediately */
-	return 0;
-}
-
 static struct dev_pm_domain default_pm_domain = {
 	.ops = {
 		.runtime_suspend = pm_clk_suspend,
 		.runtime_resume = pm_clk_resume,
-		.runtime_idle = default_platform_runtime_idle,
 		USE_PLATFORM_PM_SLEEP_OPS
 	},
 };
-- 
1.7.9.5

Re: [PATCH v3 1/3] drivers: sh: pm_runtime does not need idle callback

[Simon Horman]

Hi Geert,

quick question: Is this series targeted at 3.16?

On Wed, May 14, 2014 at 04:45:20PM +0200, Geert Uytterhoeven wrote:
> From: Ben Dooks <ben.dooks@codethink.co.uk>
> 
> In the runtime_pm idle callback the code assumes that a NULL .runtime_idle
> entry is the same as a .runtime_idle entry that returns 0 as a result. This
> means the entry in drivers/sh/pm_runtime can be removed in favour of just
> leaving the entry NULL.
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Tested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> [r8a7779 legacy]
> ---
> v3:
>   - No changes
> v2:
>   - Add Reviewed-by, Tested-by
> ---
>  drivers/sh/pm_runtime.c |    8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/sh/pm_runtime.c b/drivers/sh/pm_runtime.c
> index 10c65eb51f85..00b82ec94442 100644
> --- a/drivers/sh/pm_runtime.c
> +++ b/drivers/sh/pm_runtime.c
> @@ -21,18 +21,10 @@
>  #include <linux/slab.h>
>  
>  #ifdef CONFIG_PM_RUNTIME
> -
> -static int default_platform_runtime_idle(struct device *dev)
> -{
> -	/* suspend synchronously to disable clocks immediately */
> -	return 0;
> -}
> -
>  static struct dev_pm_domain default_pm_domain = {
>  	.ops = {
>  		.runtime_suspend = pm_clk_suspend,
>  		.runtime_resume = pm_clk_resume,
> -		.runtime_idle = default_platform_runtime_idle,
>  		USE_PLATFORM_PM_SLEEP_OPS
>  	},
>  };
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH v3 1/3] drivers: sh: pm_runtime does not need idle callback

[Geert Uytterhoeven]

Hi Simon,

On Thu, May 15, 2014 at 1:12 AM, Simon Horman <horms@verge.net.au> wrote:
> quick question: Is this series targeted at 3.16?

Ideally yes. And since you're the drivers/sh maintainer, that should work
out fine ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v3 1/3] drivers: sh: pm_runtime does not need idle callback

[Simon Horman]

On Thu, May 15, 2014 at 08:33:41AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Thu, May 15, 2014 at 1:12 AM, Simon Horman <horms@verge.net.au> wrote:
> > quick question: Is this series targeted at 3.16?
> 
> Ideally yes. And since you're the drivers/sh maintainer, that should work
> out fine ;-)

Yes, I agree it should work out fine.