linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 1/4] ARM: shmobile: armadillo800eva reference dts: Add matching LED labels
@ 2014-05-14 14:51 Geert Uytterhoeven
  2014-05-15  7:08 ` Simon Horman
  0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2014-05-14 14:51 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm; +Cc: linux-sh, Geert Uytterhoeven, devicetree

And make the node name numbering match the label numbering.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: devicetree@vger.kernel.org
---
v3:
  - Make node name numbering match label numbering
v2:
  - New
---
 .../boot/dts/r8a7740-armadillo800eva-reference.dts |   12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
index 486007d7ffe4..f6ef73ff49e8 100644
--- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
+++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
@@ -104,17 +104,21 @@
 
 	leds {
 		compatible = "gpio-leds";
-		led1 {
+		led3 {
 			gpios = <&pfc 102 GPIO_ACTIVE_HIGH>;
+			label = "LED3";
 		};
-		led2 {
+		led4 {
 			gpios = <&pfc 111 GPIO_ACTIVE_HIGH>;
+			label = "LED4";
 		};
-		led3 {
+		led5 {
 			gpios = <&pfc 110 GPIO_ACTIVE_HIGH>;
+			label = "LED5";
 		};
-		led4 {
+		led6 {
 			gpios = <&pfc 177 GPIO_ACTIVE_HIGH>;
+			label = "LED6";
 		};
 	};
 
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v3 1/4] ARM: shmobile: armadillo800eva reference dts: Add matching LED labels
  2014-05-14 14:51 [PATCH v3 1/4] ARM: shmobile: armadillo800eva reference dts: Add matching LED labels Geert Uytterhoeven
@ 2014-05-15  7:08 ` Simon Horman
  2014-05-15  7:13   ` Geert Uytterhoeven
  0 siblings, 1 reply; 4+ messages in thread
From: Simon Horman @ 2014-05-15  7:08 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Magnus Damm, linux-sh, devicetree

Thanks,

I have queued this series up for v3.17.

If possible could you send future series with a cover letter.
It would make my life just slightly easier.

On Wed, May 14, 2014 at 04:51:19PM +0200, Geert Uytterhoeven wrote:
> And make the node name numbering match the label numbering.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: devicetree@vger.kernel.org
> ---
> v3:
>   - Make node name numbering match label numbering
> v2:
>   - New
> ---
>  .../boot/dts/r8a7740-armadillo800eva-reference.dts |   12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> index 486007d7ffe4..f6ef73ff49e8 100644
> --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> @@ -104,17 +104,21 @@
>  
>  	leds {
>  		compatible = "gpio-leds";
> -		led1 {
> +		led3 {
>  			gpios = <&pfc 102 GPIO_ACTIVE_HIGH>;
> +			label = "LED3";
>  		};
> -		led2 {
> +		led4 {
>  			gpios = <&pfc 111 GPIO_ACTIVE_HIGH>;
> +			label = "LED4";
>  		};
> -		led3 {
> +		led5 {
>  			gpios = <&pfc 110 GPIO_ACTIVE_HIGH>;
> +			label = "LED5";
>  		};
> -		led4 {
> +		led6 {
>  			gpios = <&pfc 177 GPIO_ACTIVE_HIGH>;
> +			label = "LED6";
>  		};
>  	};
>  
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3 1/4] ARM: shmobile: armadillo800eva reference dts: Add matching LED labels
  2014-05-15  7:08 ` Simon Horman
@ 2014-05-15  7:13   ` Geert Uytterhoeven
  2014-05-15  7:25     ` Simon Horman
  0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2014-05-15  7:13 UTC (permalink / raw)
  To: Simon Horman
  Cc: Geert Uytterhoeven, Magnus Damm, Linux-sh list,
	devicetree@vger.kernel.org

Hi Simon,

On Thu, May 15, 2014 at 9:08 AM, Simon Horman <horms@verge.net.au> wrote:
> I have queued this series up for v3.17.

Thanks!

> If possible could you send future series with a cover letter.
> It would make my life just slightly easier.

OK, will do. I didn't because it was just "misc Armadillo LED updates".

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3 1/4] ARM: shmobile: armadillo800eva reference dts: Add matching LED labels
  2014-05-15  7:13   ` Geert Uytterhoeven
@ 2014-05-15  7:25     ` Simon Horman
  0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2014-05-15  7:25 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Geert Uytterhoeven, Magnus Damm, Linux-sh list,
	devicetree@vger.kernel.org

On Thu, May 15, 2014 at 09:13:52AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Thu, May 15, 2014 at 9:08 AM, Simon Horman <horms@verge.net.au> wrote:
> > I have queued this series up for v3.17.
> 
> Thanks!
> 
> > If possible could you send future series with a cover letter.
> > It would make my life just slightly easier.
> 
> OK, will do. I didn't because it was just "misc Armadillo LED updates".

The main advantage for me is to have somewhere to reply with
"I've queued these up". As such its not a big deal :)

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-05-15  7:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-14 14:51 [PATCH v3 1/4] ARM: shmobile: armadillo800eva reference dts: Add matching LED labels Geert Uytterhoeven
2014-05-15  7:08 ` Simon Horman
2014-05-15  7:13   ` Geert Uytterhoeven
2014-05-15  7:25     ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).