SUPERH platform development
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH/RFC] ARM: shmobile: Enable PM_RUNTIME in defconfig
Date: Fri, 16 May 2014 08:08:26 +0000	[thread overview]
Message-ID: <20140516080825.GA23295@verge.net.au> (raw)
In-Reply-To: <CAMuHMdVEowWbMY+L1TuC4xxYvtGZiH5qYOjmd7-rt1e_=xEz1A@mail.gmail.com>

On Fri, May 16, 2014 at 09:17:03AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Fri, May 16, 2014 at 4:05 AM, Simon Horman <horms@verge.net.au> wrote:
> > I realise this change was your idea but I'd like to confirm some details.
> >
> > My assumption is that it requires
> >
> > [PATCH v4] drivers: sh: compile drivers/sh/pm_runtime.c if ARCH_SHMOBILE_MULTI
> >
> > Is that indeed required?
> > Are there other dependencies that are not in the next branch
> > of my renesas tree?
> 
> Your assumption is wrong. The aforementioned patch is always needed in
> the multi-platform case.
> 
> Please let me clarify:
> drivers/sh/pm_runtime.c registers a bus notifier for platform devices, which
> registers the default clock for automatic clock management by the PM core.
> If CONFIG_PM_RUNTIME=y, the clock will be managed dynamically, based
> on runtime requirements.
> If CONFIG_PM_RUNTIME=n, the clock will be enabled at registration time.
> 
> So even if CONFIG_PM_RUNTIME=n, you need this patch, else the affected
> clocks won't be enabled (if not already enabled by reset state or the boot
> loader).
> 
> Note that some drivers (e.g. sh-sci) will still work fine without
> drivers/sh/pm_runtime.c, as they manage their clocks themselves.

Thanks, I now understand that the above mentioned patch is required
regardless of the value of CONFIG_PM_RUNTIME.

With that in mind I'll rephrase my question: are you are ware
of any patches this one (the defconfig update) should depend on?

  reply	other threads:[~2014-05-16  8:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-16  0:04 [PATCH/RFC] ARM: shmobile: Enable PM_RUNTIME in defconfig Simon Horman
2014-05-16  2:05 ` Simon Horman
2014-05-16  7:17   ` Geert Uytterhoeven
2014-05-16  8:08     ` Simon Horman [this message]
2014-05-16  8:39       ` Geert Uytterhoeven
2014-05-16  8:55         ` Simon Horman
2014-05-16  7:18 ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140516080825.GA23295@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox