From: Ralf Baechle <ralf@linux-mips.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void
Date: Fri, 30 May 2014 15:48:59 +0000 [thread overview]
Message-ID: <20140530154859.GK17197@linux-mips.org> (raw)
In-Reply-To: <CAMuHMdV6AtjD2aqO3buzj8Eo7A7xc_+ROYnxEi2sdjMaqFiAuA@mail.gmail.com>
On Fri, May 30, 2014 at 01:39:15PM +0200, Geert Uytterhoeven wrote:
> > + if (test_bit(FLAG_REQUESTED, &chip->desc[id].flags))
> > + panic("gpio: removing gpiochip with gpios still requested\n");
>
> panic?
>
> Is this likely to happen?
And while we're at it - panic() is going to add a \n itself so don't pass a
string ending in \n to panic().
Ralf
next prev parent reply other threads:[~2014-05-30 15:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 21:54 [PATCH] gpio: removes all usage of gpiochip_remove retval abdoulaye berthe
2014-05-29 22:14 ` David Daney
[not found] ` <CABprBybQ-Jyk95zCqnoWjjyzhNyHVbsbEhb=vA5d=ZYp95_bFA@mail.gmail.com>
2014-05-29 23:40 ` Stephen Rothwell
2014-05-30 11:30 ` [PATCH 1/2] " abdoulaye berthe
2014-05-30 11:30 ` [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void abdoulaye berthe
2014-05-30 11:39 ` Geert Uytterhoeven
2014-05-30 15:48 ` Ralf Baechle [this message]
2014-05-30 17:33 ` David Daney
2014-05-30 18:16 ` Lars-Peter Clausen
[not found] ` <20140608231823.GB10112@trinity.fluff.org>
[not found] ` <53959A93.7080308@metafoo.de>
2014-06-09 13:15 ` Andrzej Hajda
[not found] ` <063D6719AE5E284EB5DD2968C1650D6D17259A1F@AcuExch.aculab.com>
2014-06-10 6:57 ` Andrzej Hajda
2014-05-29 23:25 ` [PATCH] gpio: removes all usage of gpiochip_remove retval Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140530154859.GK17197@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).