From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Fri, 27 Jun 2014 14:59:13 +0000 Subject: [PATCH] pcie-rcar: kill duplicate checks Message-Id: <201406271859.13626.sergei.shtylyov@cogentembedded.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: horms@verge.net.au, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org Cc: phil.edworthy@renesas.com The PCI core will have already checked the configuration register address before calling the {read|write}() methods, no need to check it again in these methods. Signed-off-by: Sergei Shtylyov --- The patch is against the 'next' branch of Bjorn Helgaas' 'pci.git' repo. drivers/pci/host/pcie-rcar.c | 10 ---------- 1 file changed, 10 deletions(-) Index: pci/drivers/pci/host/pcie-rcar.c =================================--- pci.orig/drivers/pci/host/pcie-rcar.c +++ pci/drivers/pci/host/pcie-rcar.c @@ -260,11 +260,6 @@ static int rcar_pcie_read_conf(struct pc struct rcar_pcie *pcie = sys_to_pcie(bus->sysdata); int ret; - if ((size = 2) && (where & 1)) - return PCIBIOS_BAD_REGISTER_NUMBER; - else if ((size = 4) && (where & 3)) - return PCIBIOS_BAD_REGISTER_NUMBER; - ret = rcar_pcie_config_access(pcie, PCI_ACCESS_READ, bus, devfn, where, val); if (ret != PCIBIOS_SUCCESSFUL) { @@ -291,11 +286,6 @@ static int rcar_pcie_write_conf(struct p int shift, ret; u32 data; - if ((size = 2) && (where & 1)) - return PCIBIOS_BAD_REGISTER_NUMBER; - else if ((size = 4) && (where & 3)) - return PCIBIOS_BAD_REGISTER_NUMBER; - ret = rcar_pcie_config_access(pcie, PCI_ACCESS_READ, bus, devfn, where, &data); if (ret != PCIBIOS_SUCCESSFUL)