Re: [PATCH] dma: sh: inherit debug options from the subsystem for sh

[Vinod Koul <vinod.koul@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 985 bytes --]

On Thu, Jul 10, 2014 at 01:56:48PM +0200, Wolfram Sang wrote:
> On Thu, Jul 03, 2014 at 02:32:25PM +0530, Vinod Koul wrote:
> > On Thu, Jul 03, 2014 at 10:48:34AM +0200, Wolfram Sang wrote:
> > > Hi,
> > > 
> > > > With dynamic debug, these flags dont make much sense unless you want something
> > > > to be printed *always* during boot.
> > > 
> > > Yes, this was exactly what I wanted. So, for consistency reasons I
> > > copied the existing mechanism over to sh. If it turns out that the
> > > desired default is something different, I'll send patches for that.
> > 
> > Ah good, and while at it, Please *do* mention this in changelog!
> > 
> > also fix the subsystem name to dmaengine in patch title
> 
> So, I assume you are okay with the change now that I gave the reason?
> But should I fix the other subdirs, too? Or keep the change minimal
> (= only for sh)?

Yes with a right reason :)

And yes makes sense to do so for whole subsystem.

-- 
~Vinod

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]