From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: Separate APMU resource data into CPU dependant part
Date: Tue, 05 Aug 2014 06:54:03 +0000 [thread overview]
Message-ID: <20140805065359.GD1534@verge.net.au> (raw)
In-Reply-To: <1407169276-25495-1-git-send-email-ulrich.hecht+renesas@gmail.com>
On Tue, Aug 05, 2014 at 02:39:15PM +0900, Magnus Damm wrote:
> On Tue, Aug 5, 2014 at 10:15 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Mon, Aug 04, 2014 at 06:21:16PM +0200, Ulrich Hecht wrote:
> >> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> >>
> >> Since APMU resource data were not common data of the R-Car series,
> >> it was separated.
> >>
> >> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> >> [uli: moved header file out of arch/arm/mach-shmobile/include/mach]
> >> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> >> ---
> >>
> >> This is needed for r8a7794 which has a set of CPU cores different from the
> >> other Gen2s.
> >
> > So unfortunate but given the facts this approach seems reasonable to me.
> > Magnus (CCed), do you have an opinion on this?
>
> This information shall really be described via DT in my option.
> Perhaps this patch could be one step in the right direction though.
> Unfortunately the patch seems to contain incorrect information though,
> the r8a7791 SoC only contains two CPU cores so now when we separate
> the code perhaps we should do it right?
>
> My suggestion is to add R-Car E2 support as UP-only first, then we can
> add SMP bits incrementally over time.
It seems to me that this would be a good candidate to skip
straight to supporting using DT rather with the option
of switching back to adding legacy-C code if a pressing need arises.
As Magnus suggests it may be easiest to achieve by focusing on
UP-only support to begin with.
prev parent reply other threads:[~2014-08-05 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 16:21 [PATCH] ARM: shmobile: Separate APMU resource data into CPU dependant part Ulrich Hecht
2014-08-05 1:15 ` Simon Horman
2014-08-05 5:39 ` Magnus Damm
2014-08-05 6:54 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140805065359.GD1534@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).