linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/3 v2] clk: shmobile: add missing 0x0100 for SDCKCR
Date: Wed, 06 Aug 2014 01:40:57 +0000	[thread overview]
Message-ID: <20140806014055.GA6876@verge.net.au> (raw)
In-Reply-To: <871tsul8b3.wl%kuninori.morimoto.gx@gmail.com>

On Wed, Aug 06, 2014 at 10:24:00AM +0900, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> 10cdfe9f327ab8d120cf6957e58c6203e3a53847
> (clk: shmobile: Add R-Car Gen2 clocks support)
> added R-Car Gen2 clock support via DT for v3.14.
> 
> But, cpg_sd01_div_table is missing
> "0x0100: x 1/8" division ratio.
> This patch fixes hidden bug.
> It is based on R-Car H2 v0.7, R-Car M2 v0.9.
> 
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reported-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thanks Morimoto-san.

Acked-by: Simon Horman <horms+renesas@verge.net.au>

Mike, could you consider picking up this patch.
It is a bug fix but it doesn't manifest as no boards use the clock in
question.

I believe the remaining two patches in this series should go though my
renesas tree.

> ---
>  drivers/clk/shmobile/clk-rcar-gen2.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/shmobile/clk-rcar-gen2.c b/drivers/clk/shmobile/clk-rcar-gen2.c
> index dff7f79..e996425 100644
> --- a/drivers/clk/shmobile/clk-rcar-gen2.c
> +++ b/drivers/clk/shmobile/clk-rcar-gen2.c
> @@ -202,6 +202,7 @@ static const struct clk_div_table cpg_sdh_div_table[] = {
>  };
>  
>  static const struct clk_div_table cpg_sd01_div_table[] = {
> +	{  4,  8 },
>  	{  5, 12 }, {  6, 16 }, {  7, 18 }, {  8, 24 },
>  	{ 10, 36 }, { 11, 48 }, { 12, 10 }, {  0,  0 },
>  };
> -- 
> 1.7.9.5
> 

  reply	other threads:[~2014-08-06  1:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-06  1:24 [PATCH 1/3 v2] clk: shmobile: add missing 0x0100 for SDCKCR Kuninori Morimoto
2014-08-06  1:40 ` Simon Horman [this message]
2014-09-02  0:44 ` Mike Turquette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140806014055.GA6876@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).