From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Wed, 06 Aug 2014 01:40:57 +0000 Subject: Re: [PATCH 1/3 v2] clk: shmobile: add missing 0x0100 for SDCKCR Message-Id: <20140806014055.GA6876@verge.net.au> List-Id: References: <871tsul8b3.wl%kuninori.morimoto.gx@gmail.com> In-Reply-To: <871tsul8b3.wl%kuninori.morimoto.gx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org On Wed, Aug 06, 2014 at 10:24:00AM +0900, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > 10cdfe9f327ab8d120cf6957e58c6203e3a53847 > (clk: shmobile: Add R-Car Gen2 clocks support) > added R-Car Gen2 clock support via DT for v3.14. > > But, cpg_sd01_div_table is missing > "0x0100: x 1/8" division ratio. > This patch fixes hidden bug. > It is based on R-Car H2 v0.7, R-Car M2 v0.9. > > Acked-by: Geert Uytterhoeven > Acked-by: Laurent Pinchart > Reported-by: Yusuke Goda > Signed-off-by: Kuninori Morimoto Thanks Morimoto-san. Acked-by: Simon Horman Mike, could you consider picking up this patch. It is a bug fix but it doesn't manifest as no boards use the clock in question. I believe the remaining two patches in this series should go though my renesas tree. > --- > drivers/clk/shmobile/clk-rcar-gen2.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/shmobile/clk-rcar-gen2.c b/drivers/clk/shmobile/clk-rcar-gen2.c > index dff7f79..e996425 100644 > --- a/drivers/clk/shmobile/clk-rcar-gen2.c > +++ b/drivers/clk/shmobile/clk-rcar-gen2.c > @@ -202,6 +202,7 @@ static const struct clk_div_table cpg_sdh_div_table[] = { > }; > > static const struct clk_div_table cpg_sd01_div_table[] = { > + { 4, 8 }, > { 5, 12 }, { 6, 16 }, { 7, 18 }, { 8, 24 }, > { 10, 36 }, { 11, 48 }, { 12, 10 }, { 0, 0 }, > }; > -- > 1.7.9.5 >