From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: lager: correct memory map
Date: Tue, 26 Aug 2014 04:20:58 +0000 [thread overview]
Message-ID: <20140826042055.GA12108@verge.net.au> (raw)
In-Reply-To: <CAOesGMieRk4Dvg=gxTgcVssARkK6DeoaVyK8619B2N5=wwo=Uw@mail.gmail.com>
On Mon, Aug 25, 2014 at 08:04:49PM -0700, Olof Johansson wrote:
> Hi,
>
> On Mon, Aug 25, 2014 at 7:53 PM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > The base address of the second memory region on the lager
> > board is 0x140000000. Update the tag used in the dts file accordingly.
> >
> > This is a documentation fix and should have no run-time affect.
> >
> > This problem was introduced when the second memory region
> > was added to the lager dts file by 62bc32a2573c4219
> > ("ARM: shmobile: Include all 4 GiB of memory on Lager)"
> > in v3.14.
> >
> > Reported-by: NAOYA SHIIBA <naoya.shiiba.nx@renesas.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > arch/arm/boot/dts/r8a7790-lager.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> > index 0118cbf..84dcafa 100644
> > --- a/arch/arm/boot/dts/r8a7790-lager.dts
> > +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> > @@ -32,7 +32,7 @@
> > reg = <0 0x40000000 0 0x40000000>;
> > };
> >
> > - memory@180000000 {
> > + memory@140000000 {
>
> That should even be "memory@1,40000000".
Two comma-separated 32bit values in the case
where a memory range starts above 4Gb?
If so it looks like this will be the first user of that syntax
(I don't see any in linux-next today).
I do however see several users of memrory@64bit_value.
Mostly other renesas fds files; ecx-2000.dts being the exception.
Should they be fixed too?
$ find -name "*.dts" | xargs grep memory@[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9]
./arch/arm/boot/dts/r8a7791-henninger.dts: memory@200000000 {
./arch/arm/boot/dts/r8a7791-koelsch.dts: memory@200000000 {
./arch/arm/boot/dts/ecx-2000.dts: memory@200000000 {
./arch/arm/boot/dts/r8a73a4-ape6evm-reference.dts: memory@200000000 {
./arch/arm/boot/dts/r8a7790-lager.dts: memory@180000000 {
./arch/arm/boot/dts/r8a73a4-ape6evm.dts: memory@200000000 {
next prev parent reply other threads:[~2014-08-26 4:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 2:53 [PATCH] ARM: shmobile: lager: correct memory map Simon Horman
2014-08-26 3:04 ` Olof Johansson
2014-08-26 4:20 ` Simon Horman [this message]
2014-08-26 7:52 ` Geert Uytterhoeven
2014-08-26 8:52 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140826042055.GA12108@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).