* [PATCH] ARM: shmobile: lager: correct memory map
@ 2014-08-26 2:53 Simon Horman
2014-08-26 3:04 ` Olof Johansson
0 siblings, 1 reply; 5+ messages in thread
From: Simon Horman @ 2014-08-26 2:53 UTC (permalink / raw)
To: linux-arm-kernel
The base address of the second memory region on the lager
board is 0x140000000. Update the tag used in the dts file accordingly.
This is a documentation fix and should have no run-time affect.
This problem was introduced when the second memory region
was added to the lager dts file by 62bc32a2573c4219
("ARM: shmobile: Include all 4 GiB of memory on Lager)"
in v3.14.
Reported-by: NAOYA SHIIBA <naoya.shiiba.nx@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm/boot/dts/r8a7790-lager.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
index 0118cbf..84dcafa 100644
--- a/arch/arm/boot/dts/r8a7790-lager.dts
+++ b/arch/arm/boot/dts/r8a7790-lager.dts
@@ -32,7 +32,7 @@
reg = <0 0x40000000 0 0x40000000>;
};
- memory@180000000 {
+ memory@140000000 {
device_type = "memory";
reg = <1 0x40000000 0 0xc0000000>;
};
--
2.0.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: shmobile: lager: correct memory map
2014-08-26 2:53 [PATCH] ARM: shmobile: lager: correct memory map Simon Horman
@ 2014-08-26 3:04 ` Olof Johansson
2014-08-26 4:20 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Olof Johansson @ 2014-08-26 3:04 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Mon, Aug 25, 2014 at 7:53 PM, Simon Horman
<horms+renesas@verge.net.au> wrote:
> The base address of the second memory region on the lager
> board is 0x140000000. Update the tag used in the dts file accordingly.
>
> This is a documentation fix and should have no run-time affect.
>
> This problem was introduced when the second memory region
> was added to the lager dts file by 62bc32a2573c4219
> ("ARM: shmobile: Include all 4 GiB of memory on Lager)"
> in v3.14.
>
> Reported-by: NAOYA SHIIBA <naoya.shiiba.nx@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> arch/arm/boot/dts/r8a7790-lager.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> index 0118cbf..84dcafa 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -32,7 +32,7 @@
> reg = <0 0x40000000 0 0x40000000>;
> };
>
> - memory@180000000 {
> + memory@140000000 {
That should even be "memory@1,40000000".
-Olof
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: shmobile: lager: correct memory map
2014-08-26 3:04 ` Olof Johansson
@ 2014-08-26 4:20 ` Simon Horman
2014-08-26 7:52 ` Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Simon Horman @ 2014-08-26 4:20 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Aug 25, 2014 at 08:04:49PM -0700, Olof Johansson wrote:
> Hi,
>
> On Mon, Aug 25, 2014 at 7:53 PM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > The base address of the second memory region on the lager
> > board is 0x140000000. Update the tag used in the dts file accordingly.
> >
> > This is a documentation fix and should have no run-time affect.
> >
> > This problem was introduced when the second memory region
> > was added to the lager dts file by 62bc32a2573c4219
> > ("ARM: shmobile: Include all 4 GiB of memory on Lager)"
> > in v3.14.
> >
> > Reported-by: NAOYA SHIIBA <naoya.shiiba.nx@renesas.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > arch/arm/boot/dts/r8a7790-lager.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> > index 0118cbf..84dcafa 100644
> > --- a/arch/arm/boot/dts/r8a7790-lager.dts
> > +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> > @@ -32,7 +32,7 @@
> > reg = <0 0x40000000 0 0x40000000>;
> > };
> >
> > - memory@180000000 {
> > + memory@140000000 {
>
> That should even be "memory@1,40000000".
Two comma-separated 32bit values in the case
where a memory range starts above 4Gb?
If so it looks like this will be the first user of that syntax
(I don't see any in linux-next today).
I do however see several users of memrory@64bit_value.
Mostly other renesas fds files; ecx-2000.dts being the exception.
Should they be fixed too?
$ find -name "*.dts" | xargs grep memory@[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9]
./arch/arm/boot/dts/r8a7791-henninger.dts: memory@200000000 {
./arch/arm/boot/dts/r8a7791-koelsch.dts: memory@200000000 {
./arch/arm/boot/dts/ecx-2000.dts: memory@200000000 {
./arch/arm/boot/dts/r8a73a4-ape6evm-reference.dts: memory@200000000 {
./arch/arm/boot/dts/r8a7790-lager.dts: memory@180000000 {
./arch/arm/boot/dts/r8a73a4-ape6evm.dts: memory@200000000 {
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: shmobile: lager: correct memory map
2014-08-26 4:20 ` Simon Horman
@ 2014-08-26 7:52 ` Geert Uytterhoeven
2014-08-26 8:52 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2014-08-26 7:52 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Aug 26, 2014 at 6:20 AM, Simon Horman <horms@verge.net.au> wrote:
>> > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
>> > index 0118cbf..84dcafa 100644
>> > --- a/arch/arm/boot/dts/r8a7790-lager.dts
>> > +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>> > @@ -32,7 +32,7 @@
>> > reg = <0 0x40000000 0 0x40000000>;
>> > };
>> >
>> > - memory@180000000 {
>> > + memory@140000000 {
>>
>> That should even be "memory@1,40000000".
>
> Two comma-separated 32bit values in the case
> where a memory range starts above 4Gb?
Yes. As #address-cells is 2, there should be two values after the "@"
(the first one may be optional if it's zero, I don't know for sure?)
> If so it looks like this will be the first user of that syntax
> (I don't see any in linux-next today).
No, "git grep '@.*,' -- arch/arm/boot/dts" shows several users.
Not all of them are 64-bit memory addresses, but some are.
> I do however see several users of memrory@64bit_value.
> Mostly other renesas fds files; ecx-2000.dts being the exception.
> Should they be fixed too?
>
> $ find -name "*.dts" | xargs grep memory@[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9]
> ./arch/arm/boot/dts/r8a7791-henninger.dts: memory@200000000 {
> ./arch/arm/boot/dts/r8a7791-koelsch.dts: memory@200000000 {
> ./arch/arm/boot/dts/ecx-2000.dts: memory@200000000 {
> ./arch/arm/boot/dts/r8a73a4-ape6evm-reference.dts: memory@200000000 {
> ./arch/arm/boot/dts/r8a7790-lager.dts: memory@180000000 {
> ./arch/arm/boot/dts/r8a73a4-ape6evm.dts: memory@200000000 {
Yes, these should be fixed, too.
It's a pity dtc doesn't complain about this.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: shmobile: lager: correct memory map
2014-08-26 7:52 ` Geert Uytterhoeven
@ 2014-08-26 8:52 ` Simon Horman
0 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2014-08-26 8:52 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Aug 26, 2014 at 09:52:10AM +0200, Geert Uytterhoeven wrote:
> On Tue, Aug 26, 2014 at 6:20 AM, Simon Horman <horms@verge.net.au> wrote:
> >> > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> >> > index 0118cbf..84dcafa 100644
> >> > --- a/arch/arm/boot/dts/r8a7790-lager.dts
> >> > +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> >> > @@ -32,7 +32,7 @@
> >> > reg = <0 0x40000000 0 0x40000000>;
> >> > };
> >> >
> >> > - memory@180000000 {
> >> > + memory@140000000 {
> >>
> >> That should even be "memory@1,40000000".
> >
> > Two comma-separated 32bit values in the case
> > where a memory range starts above 4Gb?
>
> Yes. As #address-cells is 2, there should be two values after the "@"
> (the first one may be optional if it's zero, I don't know for sure?)
>
> > If so it looks like this will be the first user of that syntax
> > (I don't see any in linux-next today).
>
> No, "git grep '@.*,' -- arch/arm/boot/dts" shows several users.
> Not all of them are 64-bit memory addresses, but some are.
Thanks, I like your grep better than mine.
> > I do however see several users of memrory@64bit_value.
> > Mostly other renesas fds files; ecx-2000.dts being the exception.
> > Should they be fixed too?
> >
> > $ find -name "*.dts" | xargs grep memory@[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9]
> > ./arch/arm/boot/dts/r8a7791-henninger.dts: memory@200000000 {
> > ./arch/arm/boot/dts/r8a7791-koelsch.dts: memory@200000000 {
> > ./arch/arm/boot/dts/ecx-2000.dts: memory@200000000 {
> > ./arch/arm/boot/dts/r8a73a4-ape6evm-reference.dts: memory@200000000 {
> > ./arch/arm/boot/dts/r8a7790-lager.dts: memory@180000000 {
> > ./arch/arm/boot/dts/r8a73a4-ape6evm.dts: memory@200000000 {
>
> Yes, these should be fixed, too.
>
> It's a pity dtc doesn't complain about this.
Indeed.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-08-26 8:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-26 2:53 [PATCH] ARM: shmobile: lager: correct memory map Simon Horman
2014-08-26 3:04 ` Olof Johansson
2014-08-26 4:20 ` Simon Horman
2014-08-26 7:52 ` Geert Uytterhoeven
2014-08-26 8:52 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).