linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: lager: Remove legacy C board code
Date: Wed, 10 Sep 2014 00:30:09 +0000	[thread overview]
Message-ID: <20140910003005.GA28662@verge.net.au> (raw)
In-Reply-To: <20140904023440.26241.39089.sendpatchset@w520>

On Fri, Sep 05, 2014 at 12:35:49PM +0900, Magnus Damm wrote:
> Hi Simon,
> 
> On Thu, Sep 4, 2014 at 9:14 PM, Simon Horman <horms@verge.net.au> wrote:
> > On Thu, Sep 04, 2014 at 08:38:02PM +0900, Magnus Damm wrote:
> >> Hi Sergei,
> >>
> >> On Thu, Sep 4, 2014 at 8:06 PM, Sergei Shtylyov
> >> <sergei.shtylyov@cogentembedded.com> wrote:
> >> > Hello.
> >> >
> >> > On 9/4/2014 6:34 AM, Magnus Damm wrote:
> >> >
> >> >> From: Magnus Damm <damm+renesas@opensource.se>
> >> >
> >> >
> >> >> The Multiplatform r8a7790 Lager board code is at this point
> >> >> in equally or better state compared to the legacy code.
> >> >
> >> >
> >> >    I think it's a bit premature to say this. For example, USBHS DT support
> >> > hasn't been merged (the .dts[i] part hasn't even been posted yet IIRC).
> >> > The USB PHY DT support also hasn't been merged.
> >>
> >> Thanks for letting us know. It may be a bit early then.
> >
> > At this point my feeling is that its better to wait if there are still
> > features in Legacy-C that haven't made it across to multiplatform yet.
> 
> I agree, waiting must be the best option. Thanks!

A general comment about removing board code:

As suggested by Arnd elsewhere, please also submit a patch to remove
#ifdef CONFIG_USE_OF from the relevant setup-*.c file when you remove
the legacy board code if the setup-*.c will thus always be compiled with
ARCH_MULTIPLATFORM which selects CONFIG_USE_OF.

  parent reply	other threads:[~2014-09-10  0:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-04  2:34 [PATCH] ARM: shmobile: lager: Remove legacy C board code Magnus Damm
2014-09-04  6:48 ` Laurent Pinchart
2014-09-04 11:04 ` Magnus Damm
2014-09-04 11:06 ` Sergei Shtylyov
2014-09-04 11:38 ` Magnus Damm
2014-09-04 12:14 ` Simon Horman
2014-09-05  3:35 ` Magnus Damm
2014-09-10  0:30 ` Simon Horman [this message]
2014-09-10  0:50 ` Magnus Damm
2014-09-10  2:01 ` Simon Horman
2014-09-10  2:11 ` Magnus Damm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140910003005.GA28662@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).