From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: Enable r8a7794 SoC in shmobile_defconfig
Date: Thu, 11 Sep 2014 01:05:05 +0000 [thread overview]
Message-ID: <20140911010505.GE10233@verge.net.au> (raw)
In-Reply-To: <5410F40D.7090704@renesas.com>
On Thu, Sep 11, 2014 at 09:59:57AM +0900, Khiem Nguyen wrote:
> Hi Simon,
> cc Ulrich,
>
> Thanks for your patch.
>
> I think it's a bit early to enable r8a7794
> in shmobile_defconfig.
>
> The accepted part of r8a7794 initial code lacked of
> arch. timer initialization code for Cortex-A7 in r8a7794 SoC.
> [PATCH 1/3] ARM: shmobile: rcar-gen2: Add CA7 arch_timer initialization for r8a7794
> http://www.spinics.net/lists/linux-sh/msg34978.html
>
> I guess (at least) that code should be merged (in current form or another)
> before r8a7794 can be enabled in shmobile_defconfig.
>
> On 9/10/2014 9:44 AM, Simon Horman wrote:
> > Support for the r8a7794 was recently added.
> > Enable it in the shmobile_defconfig to increase build coverage.
>
> IMO, the support is only enabled after the code under that config
> run correctly.
> Please correct me if I'm wrong.
The purpose of enabling r8a7794 at this point is to increase build
coverage. As the SoC support is new it doesn't create any regressions
even though the support may not be in a working form yet.
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> >
> > Based on renesas-devel-20140910v2-v3.17-rc4
> > arch/arm/configs/shmobile_defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
> > index 522275a..d7346ad 100644
> > --- a/arch/arm/configs/shmobile_defconfig
> > +++ b/arch/arm/configs/shmobile_defconfig
> > @@ -16,6 +16,7 @@ CONFIG_ARCH_R8A7740=y
> > CONFIG_ARCH_R8A7779=y
> > CONFIG_ARCH_R8A7790=y
> > CONFIG_ARCH_R8A7791=y
> > +CONFIG_ARCH_R8A7794=y
> > CONFIG_MACH_KOELSCH=y
> > CONFIG_MACH_LAGER=y
> > CONFIG_MACH_MARZEN=y
> >
>
> --
> Best regards,
> KHIEM Nguyen
>
next prev parent reply other threads:[~2014-09-11 1:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 0:44 [PATCH] ARM: shmobile: Enable r8a7794 SoC in shmobile_defconfig Simon Horman
2014-09-11 0:49 ` Simon Horman
2014-09-11 0:59 ` Khiem Nguyen
2014-09-11 1:05 ` Simon Horman [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-09-16 1:57 [GIT PULL] Fourth Round of Renesas ARM Based SoC Defconfig Updates for v3.18 Simon Horman
2014-09-16 1:57 ` [PATCH] ARM: shmobile: Enable r8a7794 SoC in shmobile_defconfig Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911010505.GE10233@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).