From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/5] ARM: shmobile: kzm9d: Remove spurious regulator base addresses
Date: Wed, 24 Sep 2014 01:13:39 +0000 [thread overview]
Message-ID: <20140924011339.GA15079@verge.net.au> (raw)
In-Reply-To: <CAMuHMdWo+gNM=GMJ4LiotDQ6LJ5Pa6F1bqyJwW5xqdunw9-AyA@mail.gmail.com>
On Wed, Sep 17, 2014 at 09:33:49AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Wed, Sep 17, 2014 at 2:48 AM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > As there is no reg property the regulator nodes should
> > not include @...
>
> You missed an important part of my comment:
>
> "However, in the absence of a unit-address, the node name must be unique."
>
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >
> > ---
> > v2
> > * First post
> > ---
> > arch/arm/boot/dts/emev2-kzm9d.dts | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/emev2-kzm9d.dts b/arch/arm/boot/dts/emev2-kzm9d.dts
> > index 50ccd15..f27fcf0 100644
> > --- a/arch/arm/boot/dts/emev2-kzm9d.dts
> > +++ b/arch/arm/boot/dts/emev2-kzm9d.dts
> > @@ -27,7 +27,7 @@
> > bootargs = "console=ttyS1,115200n81 ignore_loglevel root=/dev/nfs ip=dhcp";
> > };
> >
> > - reg_1p8v: regulator@0 {
> > + reg_1p8v: regulator {
> > compatible = "regulator-fixed";
> > regulator-name = "fixed-1.8V";
> > regulator-min-microvolt = <1800000>;
> > @@ -36,7 +36,7 @@
> > regulator-boot-on;
> > };
> >
> > - reg_3p3v: regulator@1 {
> > + reg_3p3v: regulator {
> > compatible = "regulator-fixed";
> > regulator-name = "fixed-3.3V";
> > regulator-min-microvolt = <3300000>;
>
> Now there are two "regulator" nodes.
>
> Dtc will not complain, but will assume the second contains overrides for
> first. "vddvario-supply" and "vdd33a-supply" of node "lan9220@20000000"
> will both the point to the same node, and the network may not work.
>
> You can see this yourself running
>
> dtc -I dtb -O dts arch/arm/boot/dts/emev2-kzm9d.dtb
What should we call the nodes?
next prev parent reply other threads:[~2014-09-24 1:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 0:48 [PATCH v2 0/5] ARM: shmobile: various DT files sorted by address Simon Horman
2014-09-17 0:48 ` [PATCH v2 1/5] ARM: shmobile: kzm9d: Remove spurious regulator base addresses Simon Horman
2014-09-17 7:33 ` Geert Uytterhoeven
2014-09-24 1:13 ` Simon Horman [this message]
2014-09-17 0:48 ` [PATCH v2 2/5] ARM: shmobile: r8a73a4: Remove spurious dma-multiplexer " Simon Horman
2014-09-17 0:48 ` [PATCH v2 3/5] ARM: shmobile: r7s72100: sort dtsi file by address Simon Horman
2014-09-17 0:48 ` [PATCH v2 4/5] ARM: shmobile: kzm9d: sort dts " Simon Horman
2014-09-17 0:48 ` [PATCH v2 5/5] ARM: shmobile: r8a73a4: sort dtsi " Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924011339.GA15079@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).