From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Tue, 30 Sep 2014 23:55:16 +0000 Subject: Re: [PATCH 1/2] ARM: shmobile: r8a7790: Add VSP1 devices to DT Message-Id: <20140930235516.GA1153@verge.net.au> List-Id: References: <1368173119-27345-2-git-send-email-horms+renesas@verge.net.au> In-Reply-To: <1368173119-27345-2-git-send-email-horms+renesas@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org On Tue, Sep 30, 2014 at 11:51:41AM +0300, Laurent Pinchart wrote: > Hello, > > On Tuesday 30 September 2014 13:23:53 Simon Horman wrote: > > On Mon, Sep 15, 2014 at 02:32:07AM +0300, Laurent Pinchart wrote: > > > On Sunday 14 September 2014 21:58:47 Sergei Shtylyov wrote: > > >> On 09/14/2014 03:36 AM, Laurent Pinchart wrote: > > >>> Add all available VSP1 devices. > > >>> > > >>> Signed-off-by: Laurent Pinchart > > >>> > > >>> --- > > >>> > > >>> arch/arm/boot/dts/r8a7790.dtsi | 51 ++++++++++++++++++++++++++++++++++ > > >>> 1 file changed, 51 insertions(+) > > >>> > > >>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi > > >>> b/arch/arm/boot/dts/r8a7790.dtsi index d0e1773..7f00bec 100644 > > >>> --- a/arch/arm/boot/dts/r8a7790.dtsi > > >>> +++ b/arch/arm/boot/dts/r8a7790.dtsi > > >>> @@ -600,6 +600,57 @@ > > >>> > > >>> status = "disabled"; > > >>> > > >>> }; > > >>> > > >>> + vsp1@fe920000 { > > >> > > >> Can't we call this node "video" or something alike (to comply with > > >> ePAPR)? > > > > > > I don't mind renaming the node, but "video" sounds too generic to me (and > > > possibly misleading, as people might expect a video node to correspond to > > > a video output device). > > > > Hi, > > > > I am wondering if there has been a conclusion to this discussion. > > Not that I know of. Unless someone comes up with a better node name, let's > stick with "vsp1". No name seems to have been forthcoming for two weeks. Accordingly, I have queued up this patch for v3.19. Likewise for the similar patch for the r8a7791. I'm more than happy to consider any name change patches that subsequently materialise.