From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] ARM: shmobile: r8a7790: Add RGX clock to device tree
Date: Fri, 10 Oct 2014 01:26:04 +0000 [thread overview]
Message-ID: <20141010012603.GH5856@verge.net.au> (raw)
In-Reply-To: <CAMuHMdV59fkhAxGrvx4VERWPm5v4roy1WNVyPAO73+W-bPn16A@mail.gmail.com>
On Thu, Oct 09, 2014 at 02:27:07PM +0200, Geert Uytterhoeven wrote:
> Hi Kaneko-san, Abe-san,
>
> On Thu, Oct 9, 2014 at 12:03 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
> > From: Kouei Abe <kouei.abe.cp@renesas.com>
>
> Thanks for your patches!
>
> > Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com>
> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> > ---
> > arch/arm/boot/dts/r8a7790.dtsi | 9 +++++----
> > include/dt-bindings/clock/r8a7790-clock.h | 1 +
> > 2 files changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> > index 2380fd5..27c038c 100644
> > --- a/arch/arm/boot/dts/r8a7790.dtsi
> > +++ b/arch/arm/boot/dts/r8a7790.dtsi
>
> > clock-output-names > > - "jpu", "tmu1", "tmu3", "tmu2", "cmt0", "tmu0", "vsp1-du1",
> > - "vsp1-du0", "vsp1-rt", "vsp1-sy";
> > + "jpu", "tmu1", "pvrsrvkm", "tmu3", "tmu2", "cmt0", "tmu0",
> > + "vsp1-du1", "vsp1-du0", "vsp1-rt", "vsp1-sy";
>
> Why is this clock called "pvrsrvkm"?
> The datasheet calls this clock "3DG".
Good question.
I am of two minds on how to handle this:
1. Simply change the name to 3dg (simple)
2. Seek clarification from Abe-san and his team
Currently I am leaning to 1 as following the data-sheet feels like
the right thing to do.
Does anyone have an opinion on this?
> > --- a/include/dt-bindings/clock/r8a7790-clock.h
> > +++ b/include/dt-bindings/clock/r8a7790-clock.h
>
> > +#define R8A7790_CLK_PVRSRVKM 12
>
> Likewise.
>
> My comments also apply to the corresponding patch for r8a7791.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-10-10 1:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 10:03 [PATCH 0/4] ARM: shmobile: Add clock to DT Yoshihiro Kaneko
2014-10-09 10:03 ` [PATCH 1/4] ARM: shmobile: r8a7790: Add RGX clock to device tree Yoshihiro Kaneko
2014-10-09 12:27 ` Geert Uytterhoeven
2014-10-10 1:26 ` Simon Horman [this message]
2014-10-20 0:53 ` Magnus Damm
2014-10-21 16:02 ` Simon Horman
2014-10-22 9:31 ` Kouei Abe
2014-10-09 10:03 ` [PATCH 2/4] ARM: shmobile: r8a7791: Add SGX " Yoshihiro Kaneko
2014-10-09 10:03 ` [PATCH 3/4] ARM: shmobile: r8a7790: Add MMP " Yoshihiro Kaneko
2014-10-09 12:29 ` Geert Uytterhoeven
2014-10-10 1:24 ` Simon Horman
2014-10-10 2:46 ` Yoshihiro Kaneko
2014-10-09 10:03 ` [PATCH 4/4] ARM: shmobile: r8a7791: " Yoshihiro Kaneko
2014-10-14 7:01 ` [PATCH 0/4] ARM: shmobile: Add clock to DT Yoshihiro Kaneko
2014-10-14 7:01 ` [PATCH 1/4] ARM: shmobile: r8a7790: Add RGX clock to device tree Yoshihiro Kaneko
2014-10-14 7:01 ` [PATCH 2/4] ARM: shmobile: r8a7791: Add SGX " Yoshihiro Kaneko
2014-10-14 7:01 ` [PATCH 3/4] ARM: shmobile: r8a7790: Add MMP " Yoshihiro Kaneko
2014-10-14 7:01 ` [PATCH 4/4] ARM: shmobile: r8a7791: " Yoshihiro Kaneko
2014-10-14 19:30 ` [PATCH 0/4] ARM: shmobile: Add clock to DT Geert Uytterhoeven
2014-10-16 5:16 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141010012603.GH5856@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).