From: Simon Horman <horms@verge.net.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Yoshihiro Kaneko <ykaneko0929@gmail.com>,
linux-media@vger.kernel.org,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 3/3] media: soc_camera: rcar_vin: Add NV16 horizontal scaling-up support
Date: Wed, 15 Oct 2014 04:52:13 +0000 [thread overview]
Message-ID: <20141015045213.GA18646@verge.net.au> (raw)
In-Reply-To: <543D1DD1.2060700@cogentembedded.com>
On Tue, Oct 14, 2014 at 04:57:53PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 10/14/2014 10:26 AM, Yoshihiro Kaneko wrote:
>
> >From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
>
> >The scaling function had been forbidden for the capture format of
> >NV16 until now. With this patch, a horizontal scaling-up function
> >is supported to the capture format of NV16. a vertical scaling-up
> >by the capture format of NV16 is forbidden for the H/W specification.
>
> s/for/by/?
>
How about the following text?
Up until now scaling has been forbidden for the NV16 capture format. This
patch adds support for horizontal scaling-up for NV16. Vertical scaling-up
for NV16 is forbidden for by the H/W specification.
> >Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> >Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> >---
> > drivers/media/platform/soc_camera/rcar_vin.c | 19 +++++++++++++++----
> > 1 file changed, 15 insertions(+), 4 deletions(-)
>
> >diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
> >index 00bc98d..bf3588f 100644
> >--- a/drivers/media/platform/soc_camera/rcar_vin.c
> >+++ b/drivers/media/platform/soc_camera/rcar_vin.c
> [...]
> >@@ -1622,9 +1622,19 @@ static int rcar_vin_set_fmt(struct soc_camera_device *icd,
> > if (priv->error_flag = false)
> > priv->error_flag = true;
> > else {
> >- if ((pixfmt = V4L2_PIX_FMT_NV16) && (pix->width & 0x1F)) {
> >- dev_err(icd->parent, "Specified width error in NV16 format.\n");
> >- return -EINVAL;
> >+ if (pixfmt = V4L2_PIX_FMT_NV16) {
> >+ if (pix->width & 0x1F) {
> >+ dev_err(icd->parent,
> >+ "Specified width error in NV16 format. "
>
> You should indent the string more to the right, preferrably starting it
> under 'icd'.
>
> >+ "Please specify the multiple of 32.\n");
>
> Do not break the string like this. scripts/checkpatch.pl has been taught
> to not complain about long strings.
>
> >+ return -EINVAL;
> >+ }
> >+ if (pix->height != cam->height) {
> >+ dev_err(icd->parent,
> >+ "Vertical scaling-up error in NV16 format. "
> >+ "Please specify input height size.\n");
>
> Same here. Not breaking the lines helps to find the error messages in the
> code.
>
> [...]
>
> WBR, Sergei
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-10-15 4:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 6:26 [PATCH 0/3] media: soc_camera: rcar_vin: Add scaling support Yoshihiro Kaneko
2014-10-14 6:26 ` [PATCH 1/3] " Yoshihiro Kaneko
2014-10-14 19:25 ` Geert Uytterhoeven
2014-10-15 9:42 ` Yoshihiro Kaneko
2014-10-14 6:26 ` [PATCH 2/3] media: soc_camera: rcar_vin: Add capture width check for NV16 format Yoshihiro Kaneko
2014-10-14 6:26 ` [PATCH 3/3] media: soc_camera: rcar_vin: Add NV16 horizontal scaling-up support Yoshihiro Kaneko
2014-10-14 12:57 ` Sergei Shtylyov
2014-10-15 4:52 ` Simon Horman [this message]
2014-10-15 14:40 ` Sergei Shtylyov
2014-10-16 4:55 ` Simon Horman
2014-10-16 5:18 ` Yoshihiro Kaneko
2014-10-15 9:41 ` Yoshihiro Kaneko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141015045213.GA18646@verge.net.au \
--to=horms@verge.net.au \
--cc=g.liakhovetski@gmx.de \
--cc=linux-media@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=ykaneko0929@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).