From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonsoo Kim Date: Fri, 24 Oct 2014 02:50:14 +0000 Subject: Re: [PATCH 1/4] mm: cma: Don't crash on allocation if CMA area can't be activated Message-Id: <20141024025014.GA15243@js1304-P5Q-DELUXE> List-Id: References: <1414074828-4488-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1414074828-4488-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1463193.4qGZjcvNod@avalon> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Weijie Yang Cc: Laurent Pinchart , Michal Nazarewicz , Laurent Pinchart , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org, Marek Szyprowski , Russell King - ARM Linux On Fri, Oct 24, 2014 at 10:02:49AM +0800, Weijie Yang wrote: > On Fri, Oct 24, 2014 at 7:42 AM, Laurent Pinchart > wrote: > > Hi Michal, > > > > On Thursday 23 October 2014 18:53:36 Michal Nazarewicz wrote: > >> On Thu, Oct 23 2014, Laurent Pinchart wrote: > >> > If activation of the CMA area fails its mutex won't be initialized, > >> > leading to an oops at allocation time when trying to lock the mutex. Fix > >> > this by failing allocation if the area hasn't been successfully actived, > >> > and detect that condition by moving the CMA bitmap allocation after page > >> > block reservation completion. > >> > > >> > Signed-off-by: Laurent Pinchart > >> > > >> > >> Cc: # v3.17 > >> Acked-by: Michal Nazarewicz > > This patch is good, but how about add a active field in cma struct? > use cma->active to check whether cma is actived successfully. > I think it will make code more clear and readable. > Just my little opinion. > Or just setting cma->count to 0 would work fine. Thanks.