From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: Fix is_e2 warning
Date: Wed, 29 Oct 2014 07:42:11 +0000 [thread overview]
Message-ID: <20141029074210.GA32305@verge.net.au> (raw)
In-Reply-To: <20141029073510.357.85076.sendpatchset@w520>
On Wed, Oct 29, 2014 at 04:35:10PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
>
> Fix "is_e2" warning introduced by:
>
> 9ce3fa6 ARM: shmobile: rcar-gen2: Add CA7 arch_timer initialization for r8a7794
>
> Only triggers on kernel configurations that have ARCH_ARM_TIMER=n.
>
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> ---
>
> arch/arm/mach-shmobile/setup-rcar-gen2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- 0001/arch/arm/mach-shmobile/setup-rcar-gen2.c
> +++ work/arch/arm/mach-shmobile/setup-rcar-gen2.c 2014-10-29 16:06:08.000000000 +0900
> @@ -52,10 +52,10 @@ void __init rcar_gen2_timer_init(void)
> {
> #if defined(CONFIG_ARM_ARCH_TIMER) || defined(CONFIG_COMMON_CLK)
> u32 mode = rcar_gen2_read_mode_pins();
> - bool is_e2 = (bool)of_find_compatible_node(NULL, NULL,
> - "renesas,r8a7794");
> #endif
> #ifdef CONFIG_ARM_ARCH_TIMER
> + bool is_e2 = (bool)of_find_compatible_node(NULL, NULL,
> + "renesas,r8a7794");
> void __iomem *base;
> int extal_mhz = 0;
> u32 freq;
Not strictly related, but I wonder if we can avoid the cast by
changing the type of is_e2 to struct device_node *. Also changing
the variable name might make sense in that scenario.
Casting makes me sad.
next prev parent reply other threads:[~2014-10-29 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 7:35 [PATCH] ARM: shmobile: Fix is_e2 warning Magnus Damm
2014-10-29 7:42 ` Simon Horman [this message]
2014-10-29 7:47 ` Magnus Damm
2014-10-29 7:58 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141029074210.GA32305@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).